security/py-bcrypt: Upgrade port to 4.3.0
ClosedPublic
Actions

Authored by michaelo on Thu, Jun 12, 8:27 AM.

Details

Reviewers

jrm
otis

Commits

R11:bc044adf0d1e: security/py-bcrypt: Upgrade port to 4.3.0

Summary

Add upstream version constraints where possible
port{clippy|fmt|lint} housekeeping
Remove devel/py-cffi from ${BUILD_DEPENDS}, and ${RUN_DEPENDS}, it is no longer required
Use ${DISTVERION} over ${PORTVERSION}, following the practices set out in, the FreeBSD Porter's Handbook

Co-authored-by: Siva Mahadevan <me@svmhdvn.name>
PR: 276049
Approved by: jrm (mentor), otis (mentor)
Changelog: https://github.com/pyca/bcrypt/tree/main?tab=readme-ov-file#430

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64822
Build 61705: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Thu, Jun 12, 8:27 AM

michaelo created this revision.

Harbormaster completed remote builds in B64789: Diff 156868.Thu, Jun 12, 8:27 AM

jrm added inline comments.Thu, Jun 12, 6:49 PM

security/py-bcrypt/pkg-descr
1–5

Add @jrm's improvements

Harbormaster completed remote builds in B64822: Diff 156929.Thu, Jun 12, 7:00 PM

jrm accepted this revision.Thu, Jun 12, 7:00 PM

This revision is now accepted and ready to land.Thu, Jun 12, 7:00 PM

michaelo marked an inline comment as done.Thu, Jun 12, 7:01 PM

Maybe we could refer to the ports rather than the python packages.

While bcrypt remains an acceptable choice for password storage, depending on
your specific use case, you may also want to consider using scrypt (via
standard library or security/py-cryptography) or argon2id (via security/py-argon2-cffi).

In D50803#1159876, @jrm wrote:

Maybe we could refer to the ports rather than the python packages.

While bcrypt remains an acceptable choice for password storage, depending on
your specific use case, you may also want to consider using scrypt (via
standard library or security/py-cryptography) or argon2id (via security/py-argon2-cffi).

Sounds good. Let me change...

Improve

This revision now requires review to proceed.Thu, Jun 12, 7:11 PM

Harbormaster completed remote builds in B64824: Diff 156931.Thu, Jun 12, 7:11 PM

jrm accepted this revision.Thu, Jun 12, 8:59 PM

This revision is now accepted and ready to land.Thu, Jun 12, 8:59 PM

Merged.

michaelo added a commit: R11:bc044adf0d1e: security/py-bcrypt: Upgrade port to 4.3.0.Fri, Jun 13, 5:53 AM