Differential D6075

Add a warning about using PORTSDIR in a *_DEPENDS line.
ClosedPublic
Actions

Authored by mat on Apr 23 2016, 8:35 AM.

Details

Reviewers

swills

Group Reviewers

portmgr

Commits

rP414167: Add a warning about using PORTSDIR in a *_DEPENDS line.

Summary

Note: This doesn't work, the $$ gets interpreted somewhere.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 3492
Build 3532: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 15528.Apr 23 2016, 8:35 AM

mat retitled this revision from to Add a warning about using PORTSDIR in a *_DEPENDS line..

mat updated this object.

mat edited the test plan for this revision. (Show Details)

Herald added a reviewer: portmgr. · View Herald TranscriptApr 23 2016, 8:35 AM

And working with fmake and bmake...

Herald edited edge metadata. · View Herald TranscriptApr 28 2016, 11:54 AM

Mmm, without a stray file.

Herald edited edge metadata. · View Herald TranscriptApr 28 2016, 11:55 AM

Looks good to me. Might belong in bsd.sanity.mk but perhaps it won't work there.

This revision is now accepted and ready to land.Apr 28 2016, 11:58 AM

In D6075#130577, @swills wrote:

Looks good to me. Might belong in bsd.sanity.mk but perhaps it won't work there.

No, bsd.sanity.mk is included too early for it to work, I know, I tried ;-)

Closed by commit rP414167: Add a warning about using PORTSDIR in a *_DEPENDS line. (authored by mat). · Explain WhyApr 28 2016, 12:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Mk/

bsd.port.mk

10 lines

Diff 15690

View Options

Add a warning about using PORTSDIR in a *_DEPENDS line.ClosedPublicActions