Page MenuHomeFreeBSD
Differential D6075

Add a warning about using PORTSDIR in a *_DEPENDS line.
ClosedPublic
Actions

Authored by mat on Apr 23 2016, 8:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 24, 12:21 AM
Unknown Object (File)
Sat, Nov 22, 9:30 AM
Unknown Object (File)
Sat, Nov 22, 9:30 AM
Unknown Object (File)
Sat, Nov 22, 9:29 AM
Unknown Object (File)
Sat, Nov 22, 9:29 AM
Unknown Object (File)
Sat, Nov 22, 9:29 AM
Unknown Object (File)
Sat, Nov 22, 9:19 AM
Unknown Object (File)
Wed, Nov 19, 3:03 AM
View All Files
Subscribers
swills

Details

Reviewers
swills
Group Reviewers
portmgr
Commits
rP414167: Add a warning about using PORTSDIR in a *_DEPENDS line.
Summary

Note: This doesn't work, the $$ gets interpreted somewhere.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 3491
Build 3531: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 15528.Apr 23 2016, 8:35 AM
mat retitled this revision from to Add a warning about using PORTSDIR in a *_DEPENDS line..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
Herald added a reviewer: portmgr. · View Herald TranscriptApr 23 2016, 8:35 AM
mat updated this revision to Diff 15689.Apr 28 2016, 11:54 AM
mat edited edge metadata.
  • And working with fmake and bmake...
Herald edited edge metadata. · View Herald TranscriptApr 28 2016, 11:54 AM
mat updated this revision to Diff 15690.Apr 28 2016, 11:55 AM
mat edited edge metadata.

Mmm, without a stray file.

Herald edited edge metadata. · View Herald TranscriptApr 28 2016, 11:55 AM
swills accepted this revision.Apr 28 2016, 11:58 AM
swills added a reviewer: swills.
swills added a subscriber: swills.

Looks good to me. Might belong in bsd.sanity.mk but perhaps it won't work there.

This revision is now accepted and ready to land.Apr 28 2016, 11:58 AM
mat added a comment.Apr 28 2016, 12:04 PM
In D6075#130577, @swills wrote:

Looks good to me. Might belong in bsd.sanity.mk but perhaps it won't work there.

No, bsd.sanity.mk is included too early for it to work, I know, I tried ;-)

Closed by commit rP414167: Add a warning about using PORTSDIR in a *_DEPENDS line. (authored by mat). · Explain WhyApr 28 2016, 12:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
10 lines
dns/
bind910/
files/
11 lines

Diff 15689

View Options

Mk/bsd.port.mk

Loading...
View Options

dns/bind910/files/patch-bin_tests_system_dlzexternal_Makefile.in

Loading...