Differential D50800

fusefs: don't fake the mountpoint's stat info before FUSE_INIT completes
ClosedPublic
Actions

Authored by asomers on Jun 11 2025, 9:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 4, 1:50 PM

	Unknown Object (File)
	Tue, Aug 26, 10:18 AM

	Unknown Object (File)
	Tue, Aug 26, 10:01 AM

	Unknown Object (File)
	Mon, Aug 25, 7:43 PM

	Unknown Object (File)
	Mon, Aug 25, 6:54 PM

	Unknown Object (File)
	Mon, Aug 25, 5:02 AM

	Unknown Object (File)
	Fri, Aug 22, 12:31 PM

	Unknown Object (File)
	Fri, Aug 22, 1:39 AM

View All 35 Files

Subscribers

Details

Reviewers

Commits

rG9e682c426093: fusefs: don't fake the mountpoint's stat info before FUSE_INIT completes

Summary

Ever since the first GSoC contribution, fusefs has had a curious
behavior. If the daemon hasn't finished responding to FUSE_INIT,
fuse_vnop_getattr would reply to VOP_GETATTR requests for the mountpoint
by returning all zeros. I don't know why. It isn't necessary for
unmounting, even if the daemon is dead.

Delete that behavior. Now VOP_GETATTR for the mountpoint will wait for
the daemon to be ready, just like it will for any other vnode.

Reported by: Vassili Tchersky
MFC after: 2 weeks
Sponsored by: ConnectWise

Test Plan

Test case added

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64770
Build 61654: arc lint + arc unit

Event Timeline

asomers created this revision.Jun 11 2025, 9:41 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 11 2025, 9:41 PM

asomers requested review of this revision.Jun 11 2025, 9:41 PM

Harbormaster completed remote builds in B64770: Diff 156845.Jun 11 2025, 9:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2025, 10:53 PM

Closed by commit rG9e682c426093: fusefs: don't fake the mountpoint's stat info before FUSE_INIT completes (authored by asomers). · Explain Why

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG9e682c426093: fusefs: don't fake the mountpoint's stat info before FUSE_INIT completes.

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

34 lines

tests/

sys/

fs/

fusefs/

1 line

3 lines

6 lines

105 lines

2 lines

3 lines

Diff 156845

sys/fs/fuse/fuse_vnops.c

Loading...

tests/sys/fs/fusefs/Makefile

Loading...

tests/sys/fs/fusefs/mockfs.hh

Loading...

tests/sys/fs/fusefs/mockfs.cc

Loading...

tests/sys/fs/fusefs/pre-init.cc

Loading...

tests/sys/fs/fusefs/utils.hh

Loading...

tests/sys/fs/fusefs/utils.cc

Loading...