Page MenuHomeFreeBSD
Differential D50667

linuxkpi: Improve LKPI_80211_TRACE_MO message
ClosedPublic
Actions

Authored by emaste on Tue, Jun 3, 2:17 PM.
Tags
None
Referenced Files
F120122029: D50667.id156486.diff
Sun, Jun 15, 7:18 AM
Unknown Object (File)
Fri, Jun 13, 1:52 AM
Unknown Object (File)
Thu, Jun 12, 9:35 PM
Unknown Object (File)
Mon, Jun 9, 7:25 AM
Unknown Object (File)
Sun, Jun 8, 6:18 AM
Unknown Object (File)
Tue, Jun 3, 9:00 PM
Subscribers
imp
linuxkpi

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rGe578e6507c00: linuxkpi: Improve LKPI_80211_TRACE_MO message
Summary
The message used to have a prefix of the function and line, followed by
`:_` and the supplied message.  Commit 3206587a20de changed the prefix
to add the CPU, tid, and ticks.  `_` and the user-supplied message were
joined to the ticks value.  Instead use `: ` to separate them.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Tue, Jun 3, 2:17 PM
Herald added a subscriber: linuxkpi. · View Herald TranscriptTue, Jun 3, 2:17 PM
emaste requested review of this revision.Tue, Jun 3, 2:17 PM
emaste added a comment.Tue, Jun 3, 2:23 PM

I'm getting a lot of these on my WIP kernel and am not sure if this is due to any in-progress changes or something in my wireless environment. That prompted me to look into the slightly odd-looking message format:

[428514.937200] LKPI_80211_TRACE_MO lkpi_80211_mo_wake_tx_queue:652: 7 100033 2575397956_hw 0xfffffe01810ae480 txq 0xfffff8000c5ff880
[428514.937273] LKPI_80211_TRACE_MO lkpi_80211_mo_wake_tx_queue:652: 7 100033 2575397956_hw 0xfffffe01810ae480 txq 0xfffff8000c5ff880
[428514.956024] LKPI_80211_TRACE_MO lkpi_80211_mo_wake_tx_queue:652: 4 100033 2575397974_hw 0xfffffe01810ae480 txq 0xfffff8000c5ff880
[428515.238133] LKPI_80211_TRACE_MO lkpi_80211_mo_wake_tx_queue:652: 7 100033 2575398256_hw 0xfffffe01810ae480 txq 0xfffff8000c5ff880
[428515.282541] LKPI_80211_TRACE_MO lkpi_80211_mo_wake_tx_queue:652: 5 100033 2575398301_hw 0xfffffe01810ae480 txq 0xfffff8000c5ff880
[428515.354031] LKPI_80211_TRACE_MO lkpi_80211_mo_wake_tx_queue:652: 5 100033 2575398372_hw 0xfffffe01810ae480 txq 0xfffff8000c5ff880
[428515.405563] LKPI_80211_TRACE_MO lkpi_80211_mo_wake_tx_queue:652: 3 100033 2575398423_hw 0xfffffe01810ae480 txq 0xfffff8000c5ff880
[428515.573379] LKPI_80211_TRACE_MO lkpi_80211_mo_wake_tx_queue:652: 3 100033 2575398591_hw 0xfffffe01810ae480 txq 0xfffff8000c5ff880
[428515.642131] LKPI_80211_TRACE_MO lkpi_80211_mo_wake_tx_queue:652: 1 100033 2575398659_hw 0xfffffe01810ae480 txq 0xfffff8000c5ff880
[428515.642251] LKPI_80211_TRACE_MO lkpi_80211_mo_wake_tx_queue:652: 1 100033 2575398660_hw 0xfffffe01810ae480 txq 0xfffff8000c5ff880
emaste added a comment.Tue, Jun 3, 2:29 PM

I had a leftover compat.linuxkpi.80211.debug=0x00100000 in loader.conf

bz accepted this revision.Tue, Jun 3, 6:42 PM
This revision is now accepted and ready to land.Tue, Jun 3, 6:42 PM
Closed by commit rGe578e6507c00: linuxkpi: Improve LKPI_80211_TRACE_MO message (authored by emaste). · Explain WhyTue, Jun 3, 6:46 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGe578e6507c00: linuxkpi: Improve LKPI_80211_TRACE_MO message.
Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 3, 6:46 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
2 lines

Diff 156486

View Options

sys/compat/linuxkpi/common/src/linux_80211_macops.c

Loading...