Page MenuHomeFreeBSD

x11/boomer: fix mitshm compile and add as default
Needs ReviewPublic

Authored by aokblast on Sat, May 3, 8:26 AM.
Tags
None
Referenced Files
F117729597: D50130.diff
Thu, May 22, 8:49 AM
Unknown Object (File)
Thu, May 15, 2:24 PM
Unknown Object (File)
Mon, May 12, 2:35 AM
Subscribers

Details

Reviewers
danfe
Summary

The mitshm compile is needed for multiple screen.
When copying the whole image, it takes 10 secs to take the screenshot
for 1 4k monitor and 2 2k monitor in my setup.
When mitshm is enable, it has no delay and can scrool immediately

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 64203
Build 61087: arc lint + arc unit

Event Timeline

aokblast created this revision.

The mitshm compile is needed for multiple screen. When copying the whole image, it takes 10 secs to take the screenshot

So that means that delay only occurs in the multi-screen setups? Just wondering if it's possible to reproduce it on a single-screen laptop.

x11/boomer/files/patch-src_screenshot.nim
15

Would it be possible to obtain syscall numbers from Nim somehow instead of hardcoding them?

24

This change should be explained, to be included in the commit log. If it's a bug in the original code it should probably be reported upstream.

The mitshm compile is needed for multiple screen. When copying the whole image, it takes 10 secs to take the screenshot

So that means that delay only occurs in the multi-screen setups? Just wondering if it's possible to reproduce it on a single-screen laptop.

I have tried to remove all the external monitors of my laptop and it seems no issue when there is only 1 screen.

x11/boomer/files/patch-src_screenshot.nim
15

No, nim does not provide and codegen or binding stuff. Even the syscall is implemented by inline asm.
See: https://github.com/tsoding/boomer/blob/master/src/screenshot.nim#L14

24

Some body try to fix it but obviously tsoding does not actively maintain it right now.

See: https://github.com/tsoding/boomer/issues/26#issuecomment-1820374229

This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 15, 2:23 PM
This revision was automatically updated to reflect the committed changes.

Sorry, I pushed a commit to 'src' with a wrong revision number... Trying to restore this revision to its state before that mistake.

I have roll it back. It should be ok now.