vm_object: use iterators in DB_SHOW*()
ClosedPublic
Actions

Authored by dougm on Mon, Apr 21, 7:30 PM.

Tags

None

Referenced Files

	F117290081: D49947.id154044.diff
	Fri, May 16, 9:33 AM

	Unknown Object (File)
	Mon, May 12, 12:42 AM

	Unknown Object (File)
	Fri, May 9, 8:01 AM

	Unknown Object (File)
	Thu, May 8, 12:43 PM

	Unknown Object (File)
	Wed, May 7, 2:31 PM

	Unknown Object (File)
	Sat, Apr 26, 12:59 AM

	Unknown Object (File)
	Fri, Apr 25, 10:27 PM

	Unknown Object (File)
	Fri, Apr 25, 10:45 AM

Subscribers

Details

Reviewers

kib

Commits

rG98a01518bb5e: vm_object: use iterators in DB_SHOW*()

Summary

Replace tailq pointers with iterators in the DB_SHOW* functions.

Lint

Lint Skipped

Unit

Tests Skipped

dougm requested review of this revision.Mon, Apr 21, 7:30 PM

dougm created this revision.

sys/vm/vm_object.c
2836–2837	After this 'continue', wouldn't the fidx value become invalid? IMO it should be updated for each loop iteration when the state is 'in the run'.
2838

Rewrite DB_SHOW_COMMAND_FLAGS to make it clearer.

sys/vm/vm_object.c
2836–2837	I'm using fidx improperly. In the original code, it is set at the beginning of a run and printed at the end of the run. My use of it at the top of the loop is wrong.