Page MenuHomeFreeBSD

Fix PCI bus detach to delete child devices.
ClosedPublic

Authored by jhb on Apr 20 2016, 2:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 11, 10:52 PM
Unknown Object (File)
Sat, Nov 29, 8:50 AM
Unknown Object (File)
Nov 18 2025, 10:43 AM
Unknown Object (File)
Nov 15 2025, 10:35 PM
Unknown Object (File)
Nov 15 2025, 2:45 AM
Unknown Object (File)
Nov 15 2025, 12:48 AM
Unknown Object (File)
Nov 14 2025, 6:43 PM
Unknown Object (File)
Nov 6 2025, 4:10 PM
Subscribers

Details

Summary

Fix PCI bus detach to delete child devices.

Arguably, bus_generic_detach() should be calling device_delete_children()
as most (if not all) buses should delete child devices when detaching,
but that's a larger problem to solve.

If I had my druthers I'd probably rename bus_generic_detach() to
device_detach_children() and change bus_generic_detach() to call
device_detach_children() followed by device_delete_children().

Test Plan
  • the hotplug patches detach (and delete) the PCI bus on card insertion and exercised this change

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3342
Build 3377: arc lint + arc unit