Page MenuHomeFreeBSD

secure: Adapt Makefile to ssh-sk-client everywhere
ClosedPublic

Authored by jlduran on Apr 12 2025, 2:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 23, 9:16 PM
Unknown Object (File)
Fri, Sep 19, 1:35 AM
Unknown Object (File)
Tue, Sep 16, 11:44 AM
Unknown Object (File)
Mon, Sep 15, 5:33 PM
Unknown Object (File)
Sat, Sep 13, 11:32 AM
Unknown Object (File)
Sat, Sep 13, 7:36 AM
Unknown Object (File)
Tue, Sep 9, 9:35 PM
Unknown Object (File)
Tue, Sep 9, 6:23 PM
Subscribers

Details

Summary

Upstream commit 7b47b40b1 ("adapt Makefile to ssh-sk-client everywhere")
adapted the Makefiles to ssh-sk-client. Do the same here.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

secure/libexec/ssh-keysign/Makefile
6

Do we want to also use ${SKOBJS} as upstream (and have that set in secure/ssh.mk)?

secure/libexec/ssh-keysign/Makefile
6

I'd like that, but the name should not indicate it's an object (theirs is). So ${SKSRCS} perhaps?

secure/libexec/ssh-keysign/Makefile
6

I'd like that, but the name should not indicate it's an object (theirs is). So ${SKSRCS} perhaps?

Hrmph I copy and pasted it without paying close enough attention. ${SKSRCS} makes sense.

jlduran marked 2 inline comments as done.

Address suggestions:

  • Move $(SKSRCS) to our central location (secure/ssh.mk), matching upstream Makefile.in as close as possible
This revision is now accepted and ready to land.Apr 12 2025, 4:56 PM