Page MenuHomeFreeBSD

secure: Adapt Makefile to ssh-sk-client everywhere
ClosedPublic

Authored by jlduran on Apr 12 2025, 2:35 AM.
Tags
None
Referenced Files
F147998863: D49795.diff
Sun, Mar 15, 2:45 AM
F147969016: D49795.diff
Sat, Mar 14, 10:48 PM
Unknown Object (File)
Fri, Mar 13, 10:57 AM
Unknown Object (File)
Tue, Mar 3, 9:14 PM
Unknown Object (File)
Tue, Mar 3, 5:51 PM
Unknown Object (File)
Tue, Mar 3, 6:18 AM
Unknown Object (File)
Tue, Mar 3, 12:32 AM
Unknown Object (File)
Mon, Mar 2, 11:17 AM
Subscribers

Details

Summary

Upstream commit 7b47b40b1 ("adapt Makefile to ssh-sk-client everywhere")
adapted the Makefiles to ssh-sk-client. Do the same here.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

secure/libexec/ssh-keysign/Makefile
6

Do we want to also use ${SKOBJS} as upstream (and have that set in secure/ssh.mk)?

secure/libexec/ssh-keysign/Makefile
6

I'd like that, but the name should not indicate it's an object (theirs is). So ${SKSRCS} perhaps?

secure/libexec/ssh-keysign/Makefile
6

I'd like that, but the name should not indicate it's an object (theirs is). So ${SKSRCS} perhaps?

Hrmph I copy and pasted it without paying close enough attention. ${SKSRCS} makes sense.

jlduran marked 2 inline comments as done.

Address suggestions:

  • Move $(SKSRCS) to our central location (secure/ssh.mk), matching upstream Makefile.in as close as possible
This revision is now accepted and ready to land.Apr 12 2025, 4:56 PM