Page MenuHomeFreeBSD

secure: Match SRCS with upstream Makefile.in
ClosedPublic

Authored by jlduran on Apr 12 2025, 2:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 16, 7:12 AM
Unknown Object (File)
Thu, Jan 15, 9:50 PM
Unknown Object (File)
Mon, Jan 12, 5:55 AM
Unknown Object (File)
Mon, Jan 12, 5:55 AM
Unknown Object (File)
Mon, Jan 12, 5:55 AM
Unknown Object (File)
Thu, Jan 8, 4:33 AM
Unknown Object (File)
Wed, Jan 7, 6:22 PM
Unknown Object (File)
Mon, Jan 5, 4:23 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63475
Build 60359: arc lint + arc unit

Event Timeline

Match upstream Makefile.in as close as possible.

Re progressmeter.c, OpenBSD includes it only in usr.bin/ssh/scp/Makefile and usr.bin/ssh/sftp/Makefile. I think it may be a bug in the portable-ization (from d194048f573136f1c2c34d25f951b78f4ffc7d77) that we can report to openssh-portable.

Re progressmeter.c, OpenBSD includes it only in usr.bin/ssh/scp/Makefile and usr.bin/ssh/sftp/Makefile. I think it may be a bug in the portable-ization (from d194048f573136f1c2c34d25f951b78f4ffc7d77) that we can report to openssh-portable.

Excellent! I'll report it.

Re progressmeter.c, OpenBSD includes it only in usr.bin/ssh/scp/Makefile and usr.bin/ssh/sftp/Makefile. I think it may be a bug in the portable-ization (from d194048f573136f1c2c34d25f951b78f4ffc7d77) that we can report to openssh-portable.

Done: https://bugzilla.mindrot.org/show_bug.cgi?id=3810
EDIT: I somehow managed to make this PR private (sigh!).
I'll update the commit message. Thanks for the upstream commit ID.

jlduran edited the summary of this revision. (Show Details)
  • Remove experimental XMSS_SRCS (these should be committed separately, and guarded by WITH_XMSS)
  • Remove progressmeter.c from libssh sources, it is not needed and has been reported upstream
This revision is now accepted and ready to land.Apr 12 2025, 6:04 PM
  • Remove experimental XMSS_SRCS (these should be committed separately, and guarded by WITH_XMSS)
  • Remove progressmeter.c from libssh sources, it is not needed and has been reported upstream

Note to self for future chronology examination:
https://github.com/openbsd/src/commit/77e911c735dab739b86bb02a31350b238272b3e8

This revision was automatically updated to reflect the committed changes.

Re progressmeter.c, OpenBSD includes it only in usr.bin/ssh/scp/Makefile and usr.bin/ssh/sftp/Makefile. I think it may be a bug in the portable-ization (from d194048f573136f1c2c34d25f951b78f4ffc7d77) that we can report to openssh-portable.

Let's wait for a response on OpenSSH PR 3810, from OpenBSD:

  • 77e911c735da ("move progressmeter.c to libssh")
  • e34d28941f95 ("ssh/lib hasn't worked towards our code-sharing goals...")