fts: Move private flags away from public ones.
ClosedPublic
Actions

Authored by des on Apr 8 2025, 3:26 PM.

Details

Reviewers

markj

Group Reviewers

Klara

Commits

rG413e5dca9dc5: fts: Move private flags away from public ones.
rGda59bcdefd46: fts: Move private flags away from public ones.
rG80e06d621ac5: fts: Move private flags away from public ones.

Summary

Renumber the private flags so there is a sizeable gap between them and
the public flags, making it easier to add public flags in the future.
These private flags are only ever set or read by FTS itself, so there
is no compatibility issue.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63411
Build 60295: arc lint + arc unit

Event Timeline

des created this revision.Apr 8 2025, 3:26 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 8 2025, 3:26 PM

des requested review of this revision.Apr 8 2025, 3:26 PM

Harbormaster completed remote builds in B63389: Diff 153356.Apr 8 2025, 3:26 PM

markj added a subscriber: markj.Apr 8 2025, 4:00 PM

markj added inline comments.

include/fts.h
49–64	I see a reference to FTS_NAMEONLY in ls.c, so this seems to be a de facto public flag and thus shouldn't be changed?

des added inline comments.Apr 8 2025, 5:29 PM

include/fts.h
49–64	Ah, you're right, it's a special case because it can't be passed to `fts_open()` but it gets set temporarily if passed to `fts_children()`. I'll have to revise the patch.