Page MenuHomeFreeBSD
Differential D49548

kerberos5, libcom_err, others: append to LDFLAGS instead of replacing
ClosedPublic
Actions

Authored by chs on Mar 28 2025, 1:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 24, 10:04 PM
Unknown Object (File)
Thu, Apr 23, 10:38 AM
Unknown Object (File)
Tue, Apr 21, 5:31 PM
Unknown Object (File)
Tue, Apr 21, 10:00 AM
Unknown Object (File)
Tue, Apr 21, 8:12 AM
Unknown Object (File)
Tue, Apr 21, 3:19 AM
Unknown Object (File)
Mon, Apr 20, 4:46 PM
Unknown Object (File)
Mon, Apr 20, 2:57 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
imp
Commits
rG1ac6ea8a0251: kerberos5, libcom_err, others: append to LDFLAGS instead of replacing

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 63341
Build 60225: arc lint + arc unit

Event Timeline

chs created this revision.Mar 28 2025, 1:15 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 28 2025, 1:15 AM
chs requested review of this revision.Mar 28 2025, 1:15 AM
Harbormaster completed remote builds in B63168: Diff 152778.Mar 28 2025, 1:15 AM
imp accepted this revision.Apr 4 2025, 2:56 AM

Commit "Subject" says LFLAGS instead of LDFLAGS.

This revision is now accepted and ready to land.Apr 4 2025, 2:56 AM
emaste accepted this revision.Apr 5 2025, 9:02 PM

LGTM with the nit @imp noted

chs retitled this revision from kerberos5, libcom_err, others: append to LFLAGS instead of replacing to kerberos5, libcom_err, others: append to LDFLAGS instead of replacing.Apr 5 2025, 9:17 PM
chs updated this revision to Diff 153184.Apr 5 2025, 9:17 PM

fixed the typo in the subject and review title

This revision now requires review to proceed.Apr 5 2025, 9:17 PM
Harbormaster completed remote builds in B63341: Diff 153184.Apr 5 2025, 9:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2025, 9:21 PM
Closed by commit rG1ac6ea8a0251: kerberos5, libcom_err, others: append to LDFLAGS instead of replacing (authored by chs). · Explain Why
This revision was automatically updated to reflect the committed changes.
chs added a commit: rG1ac6ea8a0251: kerberos5, libcom_err, others: append to LDFLAGS instead of replacing.

Revision Contents
Changeset List

PathSize
kerberos5/
lib/
libasn1/
2 lines
libgssapi_krb5/
2 lines
libgssapi_ntlm/
2 lines
libgssapi_spnego/
2 lines
libhdb/
2 lines
libheimbase/
2 lines
libheimntlm/
2 lines
libhx509/
2 lines
libkadm5clnt/
2 lines
libkadm5srv/
2 lines
libkafs5/
2 lines
libkdc/
2 lines
libkrb5/
2 lines
libwind/
2 lines
libexec/
digest-service/
2 lines
hprop/
2 lines
hpropd/
2 lines
ipropd-master/
2 lines
ipropd-slave/
2 lines
kadmind/
2 lines
kcm/
2 lines
kdc/
2 lines
kpasswdd/
2 lines
usr.bin/
kadmin/
2 lines
kpasswd/
2 lines
usr.sbin/
iprop-log/
2 lines
kstash/
2 lines
lib/
libcom_err/
2 lines
tools/
regression/
tls/
ttls3/
2 lines
tools/
net80211/
w00t/
2 lines

Diff 153184

View Options

kerberos5/lib/libasn1/Makefile

Loading...
View Options

kerberos5/lib/libgssapi_krb5/Makefile

Loading...
View Options

kerberos5/lib/libgssapi_ntlm/Makefile

Loading...
View Options

kerberos5/lib/libgssapi_spnego/Makefile

Loading...
View Options

kerberos5/lib/libhdb/Makefile

Loading...
View Options

kerberos5/lib/libheimbase/Makefile

Loading...
View Options

kerberos5/lib/libheimntlm/Makefile

Loading...
View Options

kerberos5/lib/libhx509/Makefile

Loading...
View Options

kerberos5/lib/libkadm5clnt/Makefile

Loading...
View Options

kerberos5/lib/libkadm5srv/Makefile

Loading...
View Options

kerberos5/lib/libkafs5/Makefile

Loading...
View Options

kerberos5/lib/libkdc/Makefile

Loading...
View Options

kerberos5/lib/libkrb5/Makefile

Loading...
View Options

kerberos5/lib/libwind/Makefile

Loading...
View Options

kerberos5/libexec/digest-service/Makefile

Loading...
View Options

kerberos5/libexec/hprop/Makefile

Loading...
View Options

kerberos5/libexec/hpropd/Makefile

Loading...
View Options

kerberos5/libexec/ipropd-master/Makefile

Loading...
View Options

kerberos5/libexec/ipropd-slave/Makefile

Loading...
View Options

kerberos5/libexec/kadmind/Makefile

Loading...
View Options

kerberos5/libexec/kcm/Makefile

Loading...
View Options

kerberos5/libexec/kdc/Makefile

Loading...
View Options

kerberos5/libexec/kpasswdd/Makefile

Loading...
View Options

kerberos5/usr.bin/kadmin/Makefile

Loading...
View Options

kerberos5/usr.bin/kpasswd/Makefile

Loading...
View Options

kerberos5/usr.sbin/iprop-log/Makefile

Loading...
View Options

kerberos5/usr.sbin/kstash/Makefile

Loading...
View Options

lib/libcom_err/Makefile

Loading...
View Options

tools/regression/tls/ttls3/Makefile

Loading...
View Options

tools/tools/net80211/w00t/Makefile.inc

Loading...