Paths

Table of Contentst

Differential D49406

devel/subversion{,-lts}: Band-aid port option BDB and deprecate for removal
ClosedPublic
Actions

Authored by michaelo on Mar 18 2025, 8:40 PM.

Tags

None

Referenced Files

	F136991944: D49406.id152414.diff
	Thu, Nov 20, 10:42 PM

	F136990955: D49406.id152461.diff
	Thu, Nov 20, 10:39 PM

	F136988811: D49406.id.diff
	Thu, Nov 20, 10:29 PM

	F136988774: D49406.id152398.diff
	Thu, Nov 20, 10:29 PM

	F136988466: D49406.id152410.diff
	Thu, Nov 20, 10:28 PM

	F136987465: D49406.diff
	Thu, Nov 20, 10:24 PM

	Unknown Object (File)
	Thu, Nov 13, 6:27 PM

	Unknown Object (File)
	Tue, Nov 11, 2:36 PM

Subscribers

None

Details

Reviewers

jrm
otis

Commits

R11:055a1041eda4: devel/subversion{,-lts}: Band-aid port option BDB and deprecate for removal

Summary

Limit BDB to supported versions (4+) by Subversion only
Pass mandatory configure option
Band-aid when enabled for some combinations with devel/apr1 and bdb in DEFAULT_VERSIONS
Deprecate it as it is deprecated upstream already for almost 12 years and about to be removed in 1.15

PR: 285495
Tested by: michaelo
Approved by: jrm (mentor), otis (mentor)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62972
Build 59856: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Mar 18 2025, 8:40 PM

michaelo created this revision.

Harbormaster completed remote builds in B62963: Diff 152398.Mar 18 2025, 8:40 PM

jrm added inline comments.Mar 19 2025, 3:26 AM

devel/subversion-lts/Makefile
110	That leading `-a` looks suspicious.
devel/subversion-lts/Makefile.common
30–31	I think you could also do: BBDB_CONFIGURE_WITH= berkley-db BBDB_CONFIGURE_ENABLE= bdb6 That will turn those both off when the option is off. If you decide to go with this, please confirm it's correct.
devel/subversion/Makefile
109	Same comment about leading `-a`.
devel/subversion/Makefile.common
30–31	Same comment from the -lts port.

Fix invalid test condition

Harbormaster completed remote builds in B62972: Diff 152410.Mar 19 2025, 6:13 AM

michaelo added inline comments.Mar 19 2025, 6:14 AM

devel/subversion-lts/Makefile.common
30–31	Good tip, let me evaluate this one.

Add improvements from @jrm.

Harbormaster completed remote builds in B62976: Diff 152414.Mar 19 2025, 7:56 AM

jrm accepted this revision.Mar 20 2025, 4:32 AM

This revision is now accepted and ready to land.Mar 20 2025, 4:32 AM

Closed by commit R11:055a1041eda4: devel/subversion{,-lts}: Band-aid port option BDB and deprecate for removal (authored by michaelo). · Explain WhyMar 20 2025, 10:11 AM

This revision was automatically updated to reflect the committed changes.

michaelo added a commit: R11:055a1041eda4: devel/subversion{,-lts}: Band-aid port option BDB and deprecate for removal.

Revision Contents
Changeset List

Path

Size

devel/

subversion-lts/

6 lines

Makefile.common

2 lines

files/

3 lines

subversion/

6 lines

Makefile.common

2 lines

files/

3 lines

Diff 152410

devel/subversion-lts/Makefile

Loading...

devel/subversion-lts/Makefile.common

Loading...

devel/subversion-lts/files/pkg-message.in

Loading...

devel/subversion/Makefile

Loading...

devel/subversion/Makefile.common

Loading...

devel/subversion/files/pkg-message.in

Loading...