Details
- Reviewers
jrm - Commits
- R9:1ba292a79606: [phb][Uses]: Add missing Uses=emacs
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 62421 Build 59305: arc lint + arc unit
Event Timeline
| documentation/content/en/books/porters-handbook/uses/_index.adoc | ||
|---|---|---|
| 504 | I guess this is unintentional. | |
| 516 | ||
| 519–522 | ||
| 523–524 | ||
| 528–533 | This is not for package:editors/emacs[] ports. It's for ports with USES=emacs. Given this was unclear, I propose we tweak the documentation in Mk/Uses/emacs.mk and here. | |
| 546 | ||
| 551 | ||
| 560 | ||
| 563 | ||
| 572 | We might as well go with the latest here. | |
| 575 | ||
| documentation/content/en/books/porters-handbook/uses/_index.adoc | ||
|---|---|---|
| 517 | I just tried rendering the chapter after your updates. Things look good, but this line is part of the previous line. There are a few other minor rendering issues with indentation. It would be easier for me to commandeer the review, make the changes, and then let you commandeer it back. Is that ok with you? | |
| documentation/content/en/books/porters-handbook/uses/_index.adoc | ||
|---|---|---|
| 517 | Sure thing. Thanks. | |
Looks like I didn't need to commandeer the review to make changes.
This renders a little better than the plain text in Mk/Uses/emacs.mk. I'm good if you're good. Thanks for helping to get this in the Porter's Handbook.