Paths

Table of Contentst

-
net-mgmt/nagios/
-
nagios/
-
Makefile

[PATCH] net-mgmt/nagios: Add monplugins flavor
ClosedPublic
Actions

Authored by kiwi on Dec 19 2024, 12:19 PM.

Details

Reviewers

0mp
joneum

Commits

R11:0fb561611ee8: net-mgmt/nagios: Add monplugins flavor

Summary

net-mgmt/nagios: Add monplugins flavor

Some users asked to add a flavor to permit to have nagios already
packaged with monplugins.

PR:    283977
Sponsored by:   Klara, Inc.
Approved by:    0mp (mentor)
Approved by:    joneum (maintainer)

Test Plan

Tested both flavors on poudriere on 13.4-RELEASE.
Portlinted and portclippied as well to check updated syntax are ok.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kiwi requested review of this revision.Dec 19 2024, 12:19 PM

kiwi created this revision.

LGTM

I've got some suggestions for the commit message:

net-mgmt/nagios: Add monplugins flavor
There is no need to mention in the final commit message that this patch has been tested.

Also, please make sure to create a bugzilla ticket for this change. Not all maintainers check Phabricator.

This revision is now accepted and ready to land.Jan 6 2025, 1:51 PM

kiwi edited the summary of this revision. (Show Details)Jan 10 2025, 10:27 AM

kiwi retitled this revision from [PATCH] net-mgmt/nagios: Adding monplugins flavor to nagios to [PATCH] net-mgmt/nagios: Add monplugins flavor.

kiwi edited the summary of this revision. (Show Details)

kiwi edited the test plan for this revision. (Show Details)

Cool, thanks for the updates. Let's wait for @joneum.

LGTM :-)

Cool, please update the commit message with the entertainer's approval. I'll review it and then accept the revision.

This revision now requires changes to proceed.Jan 29 2025, 10:14 AM

Added Approved by: joneum (maintainer) in commit message

Thank you! Approved!

This revision is now accepted and ready to land.Jan 30 2025, 10:18 AM

Closed by commit R11:0fb561611ee8: net-mgmt/nagios: Add monplugins flavor (authored by kiwi). · Explain WhyJan 30 2025, 12:51 PM

This revision was automatically updated to reflect the committed changes.

kiwi added a commit: R11:0fb561611ee8: net-mgmt/nagios: Add monplugins flavor.

Revision Contents
Changeset List

Path

Size

net-mgmt/

nagios/

Makefile

13 lines

Diff 150101

View Options

net-mgmt/nagios/Makefile

Show First 20 Lines • Show All 423 Lines • ▼ Show 20 Lines	struct timex32 {
int shift;		int shift;
int32_t stabil;		int32_t stabil;
int32_t jitcnt;		int32_t jitcnt;
int32_t calcnt;		int32_t calcnt;
int32_t errcnt;		int32_t errcnt;
int32_t stbcnt;		int32_t stbcnt;
};		};

		struct ptrace_coredump32 {
		int pc_fd;
		uint32_t pc_flags;
		uint32_t pc_limit1, pc_limit2;
		};
		mgorny_gentoo.orgUnsubmitted Done Inline Actions Shouldn't this be `[16]`, given it's `void` in the other struct? mgorny_gentoo.org:* Shouldn't this be `[16]`, given it's `void*` in the other struct?


#endif /* !_COMPAT_FREEBSD32_FREEBSD32_H_ */		#endif /* !_COMPAT_FREEBSD32_FREEBSD32_H_ */

[PATCH] net-mgmt/nagios: Add monplugins flavorClosedPublicActions