ziaee@ has joined the party!
ClosedPublic
Actions

Authored by ziaee on Jan 18 2025, 12:01 AM.

Details

Reviewers

carlavilla
mhorne

Summary

Onboard new doc comitter Alexander Ziaee (ziaee@) in accordance with our
rites and traditions, while listening to Too Sweet - Macroons Project. While
here, remove a deprecated $FreeBSD$ tag.

(not yet) Approved by: mhorne, carlavilla (mentors)

Diff Detail

Repository

R9 FreeBSD doc repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61790
Build 58674: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Jan 18 2025, 12:01 AM

ziaee created this revision.

Harbormaster completed remote builds in B61790: Diff 149487.Jan 18 2025, 12:01 AM

Revert attempt to sort contrib-comitters after realizing the doc said
sorted by last name. It is not sorted by last name.

Harbormaster completed remote builds in B61791: Diff 149488.Jan 18 2025, 12:44 AM

Approved

This revision is now accepted and ready to land.Jan 18 2025, 8:52 AM

ziaee edited the summary of this revision. (Show Details)Jan 18 2025, 10:02 PM

Since this is not a critial change, you can commit without @mhorne approval :)

That's so exciting! Unfortunately, I have already failed at the very first step, I didn't fix the approved trailed in the commit log.

In D48508#1106915, @ziaee wrote:

That's so exciting! Unfortunately, I have already failed at the very first step, I didn't fix the approved trailed in the commit log.

No harm done.

Typically you would also include Differential Review: https://reviews.freebsd.org/D48508, which would result in auto-closing of this review. You can close it manually from the "Add Action" drop-down menu at the bottom.