acpi: Pass the correct device to acpi_pcib_osc
ClosedPublic
Actions

Authored by andrew on Jan 2 2025, 12:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 15, 7:48 AM

	Unknown Object (File)
	Fri, Aug 14, 5:05 AM

	Unknown Object (File)
	Thu, Aug 13, 9:20 AM

	Unknown Object (File)
	Sat, Aug 8, 3:51 PM

	Unknown Object (File)
	Sat, Aug 1, 5:47 AM

	Unknown Object (File)
	Sat, Aug 1, 2:03 AM

	Unknown Object (File)
	Sat, Aug 1, 1:26 AM

	Unknown Object (File)
	Sun, Jul 26, 10:08 AM

View All Files

Subscribers

None

Details

Reviewers

jhb
imp
garga

Commits

rGddf0b5666bf5: acpi: Pass the correct device to acpi_pcib_osc
rGb714eacb7905: acpi: Pass the correct device to acpi_pcib_osc

Summary

Fix a copy-and-paste error in acpi_pcib_request_feature where the
child device was passed into acpi_pcib_osc rather than the pcib
device.

Fixes: ba1904937d9a ("acpica: Extract _OSC parsing to a common file")
Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61455
Build 58339: arc lint + arc unit

Event Timeline

andrew requested review of this revision.Jan 2 2025, 12:40 PM

andrew created this revision.

Harbormaster completed remote builds in B61455: Diff 148669.Jan 2 2025, 12:40 PM

It works. Thanks!

This revision is now accepted and ready to land.Jan 2 2025, 2:20 PM

Good catch!

Closed by commit rGb714eacb7905: acpi: Pass the correct device to acpi_pcib_osc (authored by andrew). · Explain WhyJan 3 2025, 4:27 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGb714eacb7905: acpi: Pass the correct device to acpi_pcib_osc.

andrew added a commit: rGddf0b5666bf5: acpi: Pass the correct device to acpi_pcib_osc.Apr 8 2025, 5:44 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi_pcib_acpi.c

2 lines

Diff 148669

View Options

sys/dev/acpica/acpi_pcib_acpi.c

acpi: Pass the correct device to acpi_pcib_oscClosedPublicActions