makefs: Remove impossible if condition
ClosedPublic
Actions

Authored by emaste on Dec 29 2024, 2:44 PM.

Details

Reviewers

Commits

Summary

This test is inside the else block for if (*oldname == '.'), so *oldname cannot be '.' here.

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

emaste requested review of this revision.Dec 29 2024, 2:44 PM

emaste created this revision.

This revision is now accepted and ready to land.Dec 29 2024, 7:18 PM

This seems like the kind of thing Coverity should notice- any other lower-hanging fruit like this buried in Coverity results, by chance?

Coverity has two reports against cd9660.c. (And as an aside, doesn't have a great user interface for finding issues in a specific file.)

The buffer will be filled with ASCII character '0' instead of actual zero bytes. which someone (probably me?) set to ignore some time ago.
In cd9660_convert_structure: Leak of memory or pointers to system resources (CWE-404)

No issues like this one.

This revision was automatically updated to reflect the committed changes.

Path

Size

usr.sbin/

makefs/

6 lines