hyperv/vmbus: make hyperv eventtimer as a module
AbandonedPublic
Actions

Authored by howard0su_gmail.com on Apr 2 2016, 2:04 PM.

Details

Reviewers

Summary

Also simplify eventtimer to only support one-shot.

Test Plan

Run the following command to switch hyperv eventtimer:
sysctl kern.eventtimer.timer=HyperV

also run devinfo -v to make sure hv_et is there and under
vmbus

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3097
Build 3129: arc lint + arc unit

howard0su_gmail.com retitled this revision from to hyperv/vmbus: make hyperv eventtimer as a module.

howard0su_gmail.com updated this object.

howard0su_gmail.com edited the test plan for this revision. (Show Details)

decui_microsoft.com added inline comments.

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
292	Must we check this? It looks almost all the callers of device_get_ivars(child) don't have the check. If it's a must, we should fix the other callers of device_get_ivars() too, e.g., vmbus_read_ivar(), vmbus_write_ivar().
573	what's the meaning of "delay attach until inerrupt is on" -- I don't see how bus_generic_attach() can delay things? At this place, the vmbus doesn't have any child device yet?