Page MenuHomeFreeBSD
Differential D37634

devel/cl-asdf: Update to 3.3.7
ClosedPublic
Actions

Authored by jrm on Dec 8 2022, 5:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 8:51 AM
Unknown Object (File)
Wed, Apr 9, 11:19 AM
Unknown Object (File)
Wed, Apr 9, 11:07 AM
Unknown Object (File)
Wed, Apr 9, 8:53 AM
Unknown Object (File)
Wed, Apr 9, 5:37 AM
Unknown Object (File)
Wed, Apr 9, 4:13 AM
Unknown Object (File)
Wed, Apr 9, 4:12 AM
Unknown Object (File)
Wed, Apr 9, 4:11 AM
View All 65 Files
Subscribers
emaste
mat

Details

Reviewers
olgeni
ashish
krion
Commits
R11:0c35c3d61d20: devel/cl-asdf: Update to 3.3.7
Summary

Also:

  • resolve warnings from SBCL about the ASDF port being outdated and subsequently disabled [0] by installing version.lisp-expr
  • re-add the devel/cl-asdf-sbcl port to the tree in a subsequent commit because it is required to avoid filesystem violation errors when building *-sbcl ports with Poudriere.

[0]

WARNING: You are using ASDF version 3.3.1 (probably from (require "asdf") or loaded by quicklisp) and have an older version of ASDF (and older than 2.27 at that) registered at #P"/usr/local/lib/common-lisp/asdf/asdf.asd". Having an ASDF installed and registered is the normal way of configuring ASDF to upgrade itself, and having an old version registered is a configuration error. ASDF will ignore this configured system rather than downgrade itself. In the future, you may want to either: (a) upgrade this configured ASDF to a newer version, (b) install a newer ASDF and register it in front of the former in your configuration, or (c) uninstall or unregister this and any other old version of ASDF from your configuration. Note that the older ASDF might be registered implicitly through configuration inherited from your system installation, in which case you might have to specify :ignore-inherited-configuration in your in your ~/.config/common-lisp/source-registry.conf or other source-registry configuration file, environment variable or lisp parameter. Indeed, a likely offender is an obsolete version of the cl-asdf debian or ubuntu package, that you might want to upgrade (if a recent enough version is available) or else remove altogether (since most implementations ship with a recent asdf); if you lack the system administration rights to upgrade or remove this package, then you might indeed want to either install and register a more recent version, or use :ignore-inherited-configuration to avoid registering the old one. Please consult ASDF documentation and/or experts.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 60726
Build 57610: arc lint + arc unit

Event Timeline

jrm created this revision.Dec 8 2022, 5:06 PM
Herald added a subscriber: mat. · View Herald TranscriptDec 8 2022, 5:06 PM
jrm requested review of this revision.Dec 8 2022, 5:06 PM
Harbormaster completed remote builds in B48651: Diff 113942.Dec 8 2022, 5:06 PM
jrm updated this revision to Diff 113947.Dec 8 2022, 6:57 PM

Remove some commented code in asdf-init.lisp

Harbormaster completed remote builds in B48652: Diff 113947.Dec 8 2022, 6:57 PM
jrm updated this revision to Diff 113954.Dec 8 2022, 10:29 PM

devel/cl-asdf-sbcl: New port to install ASDF FASL for SBCL

With a few tweaks to devel/cl-asdf and re-adding devel/cl-asdf-sbcl, our common
lisp ports behave as before, unless certain conditions are not met.

Details:

  • lang/sbcl has its own bundled asdf, but it still depends on devel/cl-asdf, presumably because devel-cl-asdf installs ${LOCALBASE}/etc/asdf-init.lisp.
  • If we install (the updated) devel/cl-asdf without also installing (the re-added) devel/cl-asdf-sbcl, ASDF will start trying to write files under ${LOCALBASE}/lib/common-lisp on users' systems.
  • lang/sbcl cannot depend on devel/cl-asdf-sbcl, because this would create a dependency loop.

With this update, users can get into trouble if they install some lisp port
without also installing the assocaited fasl port. If they don't, we're back to
having asdf trying to write things under ${LOCALBASE}/lib/common-lisp.

I will take more time to look deeper into the ASDF code and documentation to see
what the best way is to eiter tell it to stop automatically building the fasl
files, or build and install everything under the user's home directory.

If we did want remove SBCL's dependecy on devel/cl-asdf, perhaps we could
decouple devel/cl-asdf and asdf-init.lisp and create a new port to just install
the configuration.

Harbormaster completed remote builds in B48656: Diff 113954.Dec 8 2022, 10:29 PM
jrm added a reviewer: krion.Dec 8 2022, 10:36 PM
jrm updated this revision to Diff 146837.Nov 22 2024, 3:29 PM

Update to 3.3.7 and re-add devel/cl-asdf-sbcl to the tree

Harbormaster completed remote builds in B60726: Diff 146837.Nov 22 2024, 3:29 PM
jrm retitled this revision from devel/cl-asdf: [WIP] Update to 3.3.6 to devel/cl-asdf: Update to 3.3.7.Nov 22 2024, 3:32 PM
jrm edited the summary of this revision. (Show Details)
jrm updated this revision to Diff 146849.Nov 22 2024, 8:24 PM
jrm edited the summary of this revision. (Show Details)

devel/cl-asdf-sbcl: Prevent the fasl file from being installed under the build/ directory.

Harbormaster completed remote builds in B60735: Diff 146849.Nov 22 2024, 8:24 PM
jrm updated this revision to Diff 147685.Dec 8 2024, 12:01 AM

Split changes into multiple reviews

Harbormaster completed remote builds in B61026: Diff 147685.Dec 8 2024, 12:01 AM
emaste added a subscriber: emaste.Dec 10 2024, 4:10 PM
jrm updated this revision to Diff 147982.Dec 15 2024, 5:52 PM

Handle removal of asdf-init.lisp

Harbormaster completed remote builds in B61171: Diff 147982.Dec 15 2024, 5:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 20 2024, 2:48 AM
Closed by commit R11:0c35c3d61d20: devel/cl-asdf: Update to 3.3.7 (authored by jrm). · Explain Why
This revision was automatically updated to reflect the committed changes.
jrm added a commit: R11:0c35c3d61d20: devel/cl-asdf: Update to 3.3.7.

Revision Contents
Changeset List

PathSize
devel/
1 line
cl-asdf-sbcl/
19 lines
7 lines
cl-asdf/
33 lines
5 lines
6 lines
files/
14 lines
80 lines

Diff 146837

View Options

devel/Makefile

Show First 20 Lines • Show All 120 Lines • ▼ Show 20 Lines
static void add_compunit(enum e_cut, char *); static void add_compunit(enum e_cut, char *);
static void add_file(char *); static void add_file(char *);
static void usage(void); static void usage(void);
int int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
int c, fflag; int c, fflag, fflagstdin;
char *temp_arg; char *temp_arg;
(void) setlocale(LC_ALL, ""); (void) setlocale(LC_ALL, "");
fflag = 0; fflag = 0;
fflagstdin = 0;
inplace = NULL; inplace = NULL;
while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1) while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1)
switch (c) { switch (c) {
case 'r': /* Gnu sed compat */ case 'r': /* Gnu sed compat */
case 'E': case 'E':
rflags = REG_EXTENDED; rflags = REG_EXTENDED;
break; break;
Show All 9 Lines case 'e':
if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL) if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL)
err(1, "malloc"); err(1, "malloc");
strcpy(temp_arg, optarg); strcpy(temp_arg, optarg);
strcat(temp_arg, "\n"); strcat(temp_arg, "\n");
add_compunit(CU_STRING, temp_arg); add_compunit(CU_STRING, temp_arg);
break; break;
case 'f': case 'f':
fflag = 1; fflag = 1;
if (strcmp(optarg, "-") == 0)
fflagstdin = 1;
add_compunit(CU_FILE, optarg); add_compunit(CU_FILE, optarg);
break; break;
case 'i': case 'i':
inplace = optarg; inplace = optarg;
ispan = 0; /* don't span across input files */ ispan = 0; /* don't span across input files */
break; break;
case 'l': case 'l':
if(setvbuf(stdout, NULL, _IOLBF, 0) != 0) if(setvbuf(stdout, NULL, _IOLBF, 0) != 0)
Show All 20 Linesmain(int argc, char *argv[])
} }
compile(); compile();
/* Continue with first and start second usage */ /* Continue with first and start second usage */
if (*argv) if (*argv)
for (; *argv; argv++) for (; *argv; argv++)
add_file(*argv); add_file(*argv);
else if (fflagstdin)
0mpAuthorUnsubmitted
Done
Inline Actions

There has to be at least one input file specified.

0mp: There has to be at least one input file specified.
exit(rval);
else else
add_file(NULL); add_file(NULL);
process(); process();
cfclose(prog, NULL); cfclose(prog, NULL);
if (fclose(stdout)) if (fclose(stdout))
err(1, "stdout"); err(1, "stdout");
exit(rval); exit(rval);
} }
Show All 27 Lines case ST_EOF:
if (script == NULL) { if (script == NULL) {
if (more != NULL) if (more != NULL)
*more = 0; *more = 0;
return (NULL); return (NULL);
} }
linenum = 0; linenum = 0;
switch (script->type) { switch (script->type) {
case CU_FILE: case CU_FILE:
if (strcmp(script->s, "-") == 0) {
if ((f = fdopen(0, "r")) == NULL)
0mpAuthorUnsubmitted
Done
Inline Actions

I am not sure if it makes any difference if I try to avoid depending on the presence of /dev/stdin by using the 0th descriptor here instead.

0mp: I am not sure if it makes any difference if I try to avoid depending on the presence of…
err(1, "%s", "stdin");
tobikUnsubmitted
Done
Inline Actions

Can this not just be f = stdin?

tobik: Can this not just be `f = stdin`?
0mpAuthorUnsubmitted
Done
Inline Actions

Good catch! The tests are still passing.

0mp: Good catch! The tests are still passing.
fname = "stdin";
0mpAuthorUnsubmitted
Done
Inline Actions

Is stdin name here alright? Perhaps it could be changed to -?

0mp: Is `stdin` name here alright? Perhaps it could be changed to `-`?
} else {
if ((f = fopen(script->s, "r")) == NULL) if ((f = fopen(script->s, "r")) == NULL)
err(1, "%s", script->s); err(1, "%s", script->s);
fname = script->s; fname = script->s;
}
state = ST_FILE; state = ST_FILE;
goto again; goto again;
case CU_STRING: case CU_STRING:
if (((size_t)snprintf(string_ident, if (((size_t)snprintf(string_ident,
sizeof(string_ident), "\"%s\"", script->s)) >= sizeof(string_ident), "\"%s\"", script->s)) >=
sizeof(string_ident) - 1) sizeof(string_ident) - 1)
(void)strcpy(string_ident + (void)strcpy(string_ident +
sizeof(string_ident) - 6, " ...\""); sizeof(string_ident) - 6, " ...\"");
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines
View Options

devel/cl-asdf-sbcl/Makefile

Show First 20 Lines • Show All 120 Lines • ▼ Show 20 Lines
static void add_compunit(enum e_cut, char *); static void add_compunit(enum e_cut, char *);
static void add_file(char *); static void add_file(char *);
static void usage(void); static void usage(void);
int int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
int c, fflag; int c, fflag, fflagstdin;
char *temp_arg; char *temp_arg;
(void) setlocale(LC_ALL, ""); (void) setlocale(LC_ALL, "");
fflag = 0; fflag = 0;
fflagstdin = 0;
inplace = NULL; inplace = NULL;
while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1) while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1)
switch (c) { switch (c) {
case 'r': /* Gnu sed compat */ case 'r': /* Gnu sed compat */
case 'E': case 'E':
rflags = REG_EXTENDED; rflags = REG_EXTENDED;
break; break;
Show All 9 Lines case 'e':
if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL) if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL)
err(1, "malloc"); err(1, "malloc");
strcpy(temp_arg, optarg); strcpy(temp_arg, optarg);
strcat(temp_arg, "\n"); strcat(temp_arg, "\n");
add_compunit(CU_STRING, temp_arg); add_compunit(CU_STRING, temp_arg);
break; break;
case 'f': case 'f':
fflag = 1; fflag = 1;
if (strcmp(optarg, "-") == 0)
fflagstdin = 1;
add_compunit(CU_FILE, optarg); add_compunit(CU_FILE, optarg);
break; break;
case 'i': case 'i':
inplace = optarg; inplace = optarg;
ispan = 0; /* don't span across input files */ ispan = 0; /* don't span across input files */
break; break;
case 'l': case 'l':
if(setvbuf(stdout, NULL, _IOLBF, 0) != 0) if(setvbuf(stdout, NULL, _IOLBF, 0) != 0)
Show All 20 Linesmain(int argc, char *argv[])
} }
compile(); compile();
/* Continue with first and start second usage */ /* Continue with first and start second usage */
if (*argv) if (*argv)
for (; *argv; argv++) for (; *argv; argv++)
add_file(*argv); add_file(*argv);
else if (fflagstdin)
0mpAuthorUnsubmitted
Done
Inline Actions

There has to be at least one input file specified.

0mp: There has to be at least one input file specified.
exit(rval);
else else
add_file(NULL); add_file(NULL);
process(); process();
cfclose(prog, NULL); cfclose(prog, NULL);
if (fclose(stdout)) if (fclose(stdout))
err(1, "stdout"); err(1, "stdout");
exit(rval); exit(rval);
} }
Show All 27 Lines case ST_EOF:
if (script == NULL) { if (script == NULL) {
if (more != NULL) if (more != NULL)
*more = 0; *more = 0;
return (NULL); return (NULL);
} }
linenum = 0; linenum = 0;
switch (script->type) { switch (script->type) {
case CU_FILE: case CU_FILE:
if (strcmp(script->s, "-") == 0) {
if ((f = fdopen(0, "r")) == NULL)
0mpAuthorUnsubmitted
Done
Inline Actions

I am not sure if it makes any difference if I try to avoid depending on the presence of /dev/stdin by using the 0th descriptor here instead.

0mp: I am not sure if it makes any difference if I try to avoid depending on the presence of…
err(1, "%s", "stdin");
tobikUnsubmitted
Done
Inline Actions

Can this not just be f = stdin?

tobik: Can this not just be `f = stdin`?
0mpAuthorUnsubmitted
Done
Inline Actions

Good catch! The tests are still passing.

0mp: Good catch! The tests are still passing.
fname = "stdin";
0mpAuthorUnsubmitted
Done
Inline Actions

Is stdin name here alright? Perhaps it could be changed to -?

0mp: Is `stdin` name here alright? Perhaps it could be changed to `-`?
} else {
if ((f = fopen(script->s, "r")) == NULL) if ((f = fopen(script->s, "r")) == NULL)
err(1, "%s", script->s); err(1, "%s", script->s);
fname = script->s; fname = script->s;
}
state = ST_FILE; state = ST_FILE;
goto again; goto again;
case CU_STRING: case CU_STRING:
if (((size_t)snprintf(string_ident, if (((size_t)snprintf(string_ident,
sizeof(string_ident), "\"%s\"", script->s)) >= sizeof(string_ident), "\"%s\"", script->s)) >=
sizeof(string_ident) - 1) sizeof(string_ident) - 1)
(void)strcpy(string_ident + (void)strcpy(string_ident +
sizeof(string_ident) - 6, " ...\""); sizeof(string_ident) - 6, " ...\"");
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines
View Options

devel/cl-asdf-sbcl/pkg-descr

Show First 20 Lines • Show All 120 Lines • ▼ Show 20 Lines
static void add_compunit(enum e_cut, char *); static void add_compunit(enum e_cut, char *);
static void add_file(char *); static void add_file(char *);
static void usage(void); static void usage(void);
int int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
int c, fflag; int c, fflag, fflagstdin;
char *temp_arg; char *temp_arg;
(void) setlocale(LC_ALL, ""); (void) setlocale(LC_ALL, "");
fflag = 0; fflag = 0;
fflagstdin = 0;
inplace = NULL; inplace = NULL;
while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1) while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1)
switch (c) { switch (c) {
case 'r': /* Gnu sed compat */ case 'r': /* Gnu sed compat */
case 'E': case 'E':
rflags = REG_EXTENDED; rflags = REG_EXTENDED;
break; break;
Show All 9 Lines case 'e':
if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL) if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL)
err(1, "malloc"); err(1, "malloc");
strcpy(temp_arg, optarg); strcpy(temp_arg, optarg);
strcat(temp_arg, "\n"); strcat(temp_arg, "\n");
add_compunit(CU_STRING, temp_arg); add_compunit(CU_STRING, temp_arg);
break; break;
case 'f': case 'f':
fflag = 1; fflag = 1;
if (strcmp(optarg, "-") == 0)
fflagstdin = 1;
add_compunit(CU_FILE, optarg); add_compunit(CU_FILE, optarg);
break; break;
case 'i': case 'i':
inplace = optarg; inplace = optarg;
ispan = 0; /* don't span across input files */ ispan = 0; /* don't span across input files */
break; break;
case 'l': case 'l':
if(setvbuf(stdout, NULL, _IOLBF, 0) != 0) if(setvbuf(stdout, NULL, _IOLBF, 0) != 0)
Show All 20 Linesmain(int argc, char *argv[])
} }
compile(); compile();
/* Continue with first and start second usage */ /* Continue with first and start second usage */
if (*argv) if (*argv)
for (; *argv; argv++) for (; *argv; argv++)
add_file(*argv); add_file(*argv);
else if (fflagstdin)
0mpAuthorUnsubmitted
Done
Inline Actions

There has to be at least one input file specified.

0mp: There has to be at least one input file specified.
exit(rval);
else else
add_file(NULL); add_file(NULL);
process(); process();
cfclose(prog, NULL); cfclose(prog, NULL);
if (fclose(stdout)) if (fclose(stdout))
err(1, "stdout"); err(1, "stdout");
exit(rval); exit(rval);
} }
Show All 27 Lines case ST_EOF:
if (script == NULL) { if (script == NULL) {
if (more != NULL) if (more != NULL)
*more = 0; *more = 0;
return (NULL); return (NULL);
} }
linenum = 0; linenum = 0;
switch (script->type) { switch (script->type) {
case CU_FILE: case CU_FILE:
if (strcmp(script->s, "-") == 0) {
if ((f = fdopen(0, "r")) == NULL)
0mpAuthorUnsubmitted
Done
Inline Actions

I am not sure if it makes any difference if I try to avoid depending on the presence of /dev/stdin by using the 0th descriptor here instead.

0mp: I am not sure if it makes any difference if I try to avoid depending on the presence of…
err(1, "%s", "stdin");
tobikUnsubmitted
Done
Inline Actions

Can this not just be f = stdin?

tobik: Can this not just be `f = stdin`?
0mpAuthorUnsubmitted
Done
Inline Actions

Good catch! The tests are still passing.

0mp: Good catch! The tests are still passing.
fname = "stdin";
0mpAuthorUnsubmitted
Done
Inline Actions

Is stdin name here alright? Perhaps it could be changed to -?

0mp: Is `stdin` name here alright? Perhaps it could be changed to `-`?
} else {
if ((f = fopen(script->s, "r")) == NULL) if ((f = fopen(script->s, "r")) == NULL)
err(1, "%s", script->s); err(1, "%s", script->s);
fname = script->s; fname = script->s;
}
state = ST_FILE; state = ST_FILE;
goto again; goto again;
case CU_STRING: case CU_STRING:
if (((size_t)snprintf(string_ident, if (((size_t)snprintf(string_ident,
sizeof(string_ident), "\"%s\"", script->s)) >= sizeof(string_ident), "\"%s\"", script->s)) >=
sizeof(string_ident) - 1) sizeof(string_ident) - 1)
(void)strcpy(string_ident + (void)strcpy(string_ident +
sizeof(string_ident) - 6, " ...\""); sizeof(string_ident) - 6, " ...\"");
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines
View Options

devel/cl-asdf/Makefile

Show First 20 Lines • Show All 120 Lines • ▼ Show 20 Lines
static void add_compunit(enum e_cut, char *); static void add_compunit(enum e_cut, char *);
static void add_file(char *); static void add_file(char *);
static void usage(void); static void usage(void);
int int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
int c, fflag; int c, fflag, fflagstdin;
char *temp_arg; char *temp_arg;
(void) setlocale(LC_ALL, ""); (void) setlocale(LC_ALL, "");
fflag = 0; fflag = 0;
fflagstdin = 0;
inplace = NULL; inplace = NULL;
while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1) while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1)
switch (c) { switch (c) {
case 'r': /* Gnu sed compat */ case 'r': /* Gnu sed compat */
case 'E': case 'E':
rflags = REG_EXTENDED; rflags = REG_EXTENDED;
break; break;
Show All 9 Lines case 'e':
if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL) if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL)
err(1, "malloc"); err(1, "malloc");
strcpy(temp_arg, optarg); strcpy(temp_arg, optarg);
strcat(temp_arg, "\n"); strcat(temp_arg, "\n");
add_compunit(CU_STRING, temp_arg); add_compunit(CU_STRING, temp_arg);
break; break;
case 'f': case 'f':
fflag = 1; fflag = 1;
if (strcmp(optarg, "-") == 0)
fflagstdin = 1;
add_compunit(CU_FILE, optarg); add_compunit(CU_FILE, optarg);
break; break;
case 'i': case 'i':
inplace = optarg; inplace = optarg;
ispan = 0; /* don't span across input files */ ispan = 0; /* don't span across input files */
break; break;
case 'l': case 'l':
if(setvbuf(stdout, NULL, _IOLBF, 0) != 0) if(setvbuf(stdout, NULL, _IOLBF, 0) != 0)
Show All 20 Linesmain(int argc, char *argv[])
} }
compile(); compile();
/* Continue with first and start second usage */ /* Continue with first and start second usage */
if (*argv) if (*argv)
for (; *argv; argv++) for (; *argv; argv++)
add_file(*argv); add_file(*argv);
else if (fflagstdin)
0mpAuthorUnsubmitted
Done
Inline Actions

There has to be at least one input file specified.

0mp: There has to be at least one input file specified.
exit(rval);
else else
add_file(NULL); add_file(NULL);
process(); process();
cfclose(prog, NULL); cfclose(prog, NULL);
if (fclose(stdout)) if (fclose(stdout))
err(1, "stdout"); err(1, "stdout");
exit(rval); exit(rval);
} }
Show All 27 Lines case ST_EOF:
if (script == NULL) { if (script == NULL) {
if (more != NULL) if (more != NULL)
*more = 0; *more = 0;
return (NULL); return (NULL);
} }
linenum = 0; linenum = 0;
switch (script->type) { switch (script->type) {
case CU_FILE: case CU_FILE:
if (strcmp(script->s, "-") == 0) {
if ((f = fdopen(0, "r")) == NULL)
0mpAuthorUnsubmitted
Done
Inline Actions

I am not sure if it makes any difference if I try to avoid depending on the presence of /dev/stdin by using the 0th descriptor here instead.

0mp: I am not sure if it makes any difference if I try to avoid depending on the presence of…
err(1, "%s", "stdin");
tobikUnsubmitted
Done
Inline Actions

Can this not just be f = stdin?

tobik: Can this not just be `f = stdin`?
0mpAuthorUnsubmitted
Done
Inline Actions

Good catch! The tests are still passing.

0mp: Good catch! The tests are still passing.
fname = "stdin";
0mpAuthorUnsubmitted
Done
Inline Actions

Is stdin name here alright? Perhaps it could be changed to -?

0mp: Is `stdin` name here alright? Perhaps it could be changed to `-`?
} else {
if ((f = fopen(script->s, "r")) == NULL) if ((f = fopen(script->s, "r")) == NULL)
err(1, "%s", script->s); err(1, "%s", script->s);
fname = script->s; fname = script->s;
}
state = ST_FILE; state = ST_FILE;
goto again; goto again;
case CU_STRING: case CU_STRING:
if (((size_t)snprintf(string_ident, if (((size_t)snprintf(string_ident,
sizeof(string_ident), "\"%s\"", script->s)) >= sizeof(string_ident), "\"%s\"", script->s)) >=
sizeof(string_ident) - 1) sizeof(string_ident) - 1)
(void)strcpy(string_ident + (void)strcpy(string_ident +
sizeof(string_ident) - 6, " ...\""); sizeof(string_ident) - 6, " ...\"");
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines
View Options

devel/cl-asdf/bsd.cl-asdf.mk

Loading...
View Options

devel/cl-asdf/distinfo

Loading...
View Options

devel/cl-asdf/files/asdf-init.lisp

Loading...
View Options

devel/cl-asdf/pkg-plist

Loading...