Differential D47652

geom: Allow BSD type '!0' partitions
ClosedPublic
Actions

Authored by jlduran on Nov 18 2024, 12:29 AM.

Tags

None

Referenced Files

	F140261969: D47652.id146777.diff
	Mon, Dec 22, 12:23 AM

	F140211704: D47652.id146628.diff
	Sun, Dec 21, 11:59 AM

	Unknown Object (File)
	Fri, Dec 5, 9:42 PM

	Unknown Object (File)
	Sat, Nov 29, 10:02 PM

	Unknown Object (File)
	Wed, Nov 26, 11:15 PM

	Unknown Object (File)
	Wed, Nov 26, 4:43 PM

	Unknown Object (File)
	Wed, Nov 26, 1:25 AM

	Unknown Object (File)
	Nov 13 2025, 1:31 AM

View All 67 Files

Subscribers

dnelson_1901_yahoo.com

Details

Reviewers

emaste
imp

Commits

rG494120df401b: geom: Allow BSD type '!0' partitions
rGa7d56527c2fd: geom: Allow BSD type '!0' partitions
rGaccf71534c61: geom: Allow BSD type '!0' partitions

Summary

Allow the creation of partition type '!0', in order to replicate the
behavior of bsdlabel -w.

Fix it by not considering "0" an invalid partition type.

Test Plan

md0=$(mdconfig -s 100m)
md1=$(mdconfig -s 100m)

bsdlabel -w "$md0"

gpart create -s bsd "$md1"
gpart add -t '!0' -b 16 "$md1"

gpart show
=>     0  204800  md0  BSD  (100M)
       0      16       - free -  (8.0K)
      16  204784    1  !0  (100M)

=>     0  204800  md1  BSD  (100M)
       0      16       - free -  (8.0K)
      16  204784    1  !0  (100M)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60651
Build 57535: arc lint + arc unit

Event Timeline

jlduran requested review of this revision.Nov 18 2024, 12:29 AM

jlduran created this revision.

Harbormaster completed remote builds in B60651: Diff 146628.Nov 18 2024, 12:29 AM

jlduran added a child revision: D47653: nanobsd: Remove dependency on bsdlabel.Nov 18 2024, 12:29 AM

dnelson_1901_yahoo.com added a subscriber: dnelson_1901_yahoo.com.Nov 18 2024, 12:54 AM

I think this is reasonable -- 0 is unused/reserved, but no reason we shouldn't be able to specify it. It's not out of range etc.

This revision is now accepted and ready to land.Nov 18 2024, 1:35 PM

emaste mentioned this in D47653: nanobsd: Remove dependency on bsdlabel.Nov 18 2024, 4:19 PM

Closed by commit rGaccf71534c61: geom: Allow BSD type '!0' partitions (authored by jlduran). · Explain WhyNov 20 2024, 10:34 PM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rGaccf71534c61: geom: Allow BSD type '!0' partitions.

jlduran added a commit: rGa7d56527c2fd: geom: Allow BSD type '!0' partitions.Dec 21 2024, 5:07 PM

jlduran added a commit: rG494120df401b: geom: Allow BSD type '!0' partitions.

Revision Contents
Changeset List

Path

Size

sys/

geom/

part/

2 lines

Diff 146628

sys/geom/part/g_part_bsd.c

Loading...