ntpd: Fix crash when bringing up net interface fails
AcceptedPublic
Actions

Authored by rcm on Mon, Nov 4, 4:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 27, 3:49 AM

	Unknown Object (File)
	Sat, Nov 23, 7:00 PM

	Unknown Object (File)
	Tue, Nov 12, 2:10 AM

	Unknown Object (File)
	Sun, Nov 10, 1:02 PM

	Unknown Object (File)
	Sun, Nov 10, 9:26 AM

	Unknown Object (File)
	Sun, Nov 10, 9:13 AM

	Unknown Object (File)
	Sun, Nov 10, 8:59 AM

Subscribers

imp

Details

Reviewers

Summary

The latest vendor import of ntp-4.2.8p18 includes a bug that can cause a
segfault in an error message related to failing to bring up an endpoint
during interface setup. This occurs due to unhandled cases in the
error-handling path that reference uninitialized or freed fields in endpt,
leading to a crash under certain conditions.

PR: 281202
Obtained from: https://bugs.ntp.org/show_bug.cgi?id=3928
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

rcm created this revision.Mon, Nov 4, 4:09 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Nov 4, 4:09 PM

rcm requested review of this revision.Mon, Nov 4, 4:09 PM

lgtm

Can you also submit a revision for the ntp port, please?

This revision is now accepted and ready to land.Mon, Nov 4, 6:27 PM

Revision Contents
Changeset List

Path

Size

contrib/

ntp/

ntpd/

ntp_io.c

4 lines

Diff 145991

View Options

ntpd: Fix crash when bringing up net interface failsAcceptedPublicActions