Page MenuHomeFreeBSD

nvmf: Fix an off by one error when scanning active namespace IDs
ClosedPublic

Authored by jhb on Nov 1 2024, 3:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 1:33 AM
Unknown Object (File)
Tue, Nov 25, 8:03 PM
Unknown Object (File)
Thu, Nov 20, 4:08 PM
Unknown Object (File)
Sun, Nov 16, 12:25 PM
Unknown Object (File)
Thu, Nov 13, 9:25 PM
Unknown Object (File)
Thu, Nov 13, 8:28 AM
Unknown Object (File)
Wed, Nov 12, 11:13 PM
Unknown Object (File)
Wed, Nov 12, 12:13 PM
Subscribers
None

Details

Summary

The active namespace list query fetches namespaces greater than the
passed in namespace ID, not greater than or equal to the passed in
namespace ID. Thus, a multi-page request should start with the last
namespace ID from the previous page, not that ID plus 1.

While here, make use of NVME_GLOBAL_NAMESPACE_TAG instead of a magic
number to handle the edge case that the last namespace ID in a page is
the largest valid namespace ID.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60342
Build 57226: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Nov 1 2024, 3:26 PM
jhb created this revision.
This revision is now accepted and ready to land.Nov 2 2024, 4:55 AM
jhb retitled this revision from nvmf: Fix an off by one error in the upper bound on active namespace IDs to nvmf: Fix an off by one error when scanning active namespace IDs.Nov 2 2024, 12:33 PM
jhb edited the summary of this revision. (Show Details)
This revision now requires review to proceed.Nov 2 2024, 12:34 PM
This revision is now accepted and ready to land.Nov 4 2024, 6:21 PM