Page MenuHomeFreeBSD

nvmf: Fix an off by one error when scanning active namespace IDs
ClosedPublic

Authored by jhb on Nov 1 2024, 3:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 8:45 PM
Unknown Object (File)
Mon, Oct 6, 2:21 AM
Unknown Object (File)
Thu, Oct 2, 4:22 AM
Unknown Object (File)
Wed, Oct 1, 11:11 PM
Unknown Object (File)
Mon, Sep 29, 1:03 AM
Unknown Object (File)
Thu, Sep 25, 1:56 AM
Unknown Object (File)
Wed, Sep 24, 1:38 AM
Unknown Object (File)
Wed, Sep 24, 1:32 AM
Subscribers
None

Details

Summary

The active namespace list query fetches namespaces greater than the
passed in namespace ID, not greater than or equal to the passed in
namespace ID. Thus, a multi-page request should start with the last
namespace ID from the previous page, not that ID plus 1.

While here, make use of NVME_GLOBAL_NAMESPACE_TAG instead of a magic
number to handle the edge case that the last namespace ID in a page is
the largest valid namespace ID.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60337
Build 57221: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Nov 1 2024, 3:26 PM
jhb created this revision.
This revision is now accepted and ready to land.Nov 2 2024, 4:55 AM
jhb retitled this revision from nvmf: Fix an off by one error in the upper bound on active namespace IDs to nvmf: Fix an off by one error when scanning active namespace IDs.Nov 2 2024, 12:33 PM
jhb edited the summary of this revision. (Show Details)
This revision now requires review to proceed.Nov 2 2024, 12:34 PM
This revision is now accepted and ready to land.Nov 4 2024, 6:21 PM