Remove bogus detach routines
ClosedPublic
Actions

Authored by jhb on Nov 1 2024, 2:21 PM.

Details

Reviewers

Commits

rGfa95268aeb8a: Remove bogus detach routines
rGfba4ef71b71e: Remove bogus detach routines
rG7ebc7d1ab76b: Remove bogus detach routines

Summary

These drivers are not bus drivers, and would need proper detach
routines that tore down state stored in the softc. Better to just
fail detach outright instead of an incorrect success.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60333
Build 57217: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Nov 1 2024, 2:21 PM

jhb created this revision.

Harbormaster completed remote builds in B60333: Diff 145852.Nov 1 2024, 2:21 PM

jhb added a parent revision: D47388: dpaa2_mc: Check for error the first time bus_generic_detach is called.Nov 1 2024, 2:21 PM

jhb added a child revision: D47390: hifn/safe: Remove dummy calls to bus_generic_detach.

imp accepted this revision.Nov 2 2024, 4:58 AM

This revision is now accepted and ready to land.Nov 2 2024, 4:58 AM

Closed by commit rG7ebc7d1ab76b: Remove bogus detach routines (authored by jhb). · Explain WhyNov 5 2024, 1:34 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7ebc7d1ab76b: Remove bogus detach routines.

jhb added a commit: rGfba4ef71b71e: Remove bogus detach routines.Dec 1 2024, 4:59 AM

jhb added a commit: rGfa95268aeb8a: Remove bogus detach routines.Dec 1 2024, 5:03 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

gpio/

gpiomdio.c

1 line

sff/

sfp_fdt.c

1 line

Diff 145852

View Options

sys/dev/gpio/gpiomdio.c