vf_i2c: Don't hold a mutex across bus_generic_detach
ClosedPublic
Actions

Authored by jhb on Oct 21 2024, 2:35 PM.

Tags

None

Referenced Files

	F144047359: D47221.id145784.diff
	Tue, Feb 3, 9:37 PM

	Unknown Object (File)
	Mon, Feb 2, 4:08 PM

	Unknown Object (File)
	Mon, Feb 2, 9:49 AM

	Unknown Object (File)
	Fri, Jan 30, 2:41 PM

	Unknown Object (File)
	Wed, Jan 28, 1:14 PM

	Unknown Object (File)
	Wed, Jan 28, 2:05 AM

	Unknown Object (File)
	Dec 16 2025, 5:27 AM

	Unknown Object (File)
	Dec 15 2025, 9:25 PM

View All 79 Files

Subscribers

None

Details

Reviewers

imp

Commits

rGe09c819e6a4c: vf_i2c: Don't hold a mutex across bus_generic_detach
rG13a1dbfed57b: vf_i2c: Don't hold a mutex across bus_generic_detach

Summary

This was also leaking the lock if bus_generic_detach failed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Oct 21 2024, 2:35 PM

jhb created this revision.

Harbormaster completed remote builds in B60121: Diff 145274.Oct 21 2024, 2:35 PM

jhb added a parent revision: D47220: ignore_pci: Add a proper stub attach routine.Oct 21 2024, 2:35 PM

jhb added a child revision: D47222: csa: Use pci_find_device to simplify clkrun_hack.

Nice catch

This revision is now accepted and ready to land.Oct 31 2024, 5:04 PM

Closed by commit rG13a1dbfed57b: vf_i2c: Don't hold a mutex across bus_generic_detach (authored by jhb). · Explain WhyOct 31 2024, 7:53 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG13a1dbfed57b: vf_i2c: Don't hold a mutex across bus_generic_detach.

jhb added a commit: rGe09c819e6a4c: vf_i2c: Don't hold a mutex across bus_generic_detach.Dec 1 2024, 4:58 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

iicbus/

controller/

vybrid/

vf_i2c.c

14 lines

Diff 145784

View Options

sys/dev/iicbus/controller/vybrid/vf_i2c.c

vf_i2c: Don't hold a mutex across bus_generic_detachClosedPublicActions