Differential D47293

igc: Fix a bogus register write in igc_if_queues_free()
ClosedPublic
Actions

Authored by markj on Oct 26 2024, 5:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 20, 2:19 AM

	Unknown Object (File)
	Fri, Dec 5, 5:26 AM

	Unknown Object (File)
	Wed, Nov 26, 10:32 PM

	Unknown Object (File)
	Tue, Nov 25, 5:31 PM

	Unknown Object (File)
	Sun, Nov 23, 2:20 AM

	Unknown Object (File)
	Nov 18 2025, 11:30 AM

	Unknown Object (File)
	Nov 18 2025, 8:00 AM

	Unknown Object (File)
	Nov 16 2025, 2:22 AM

View All 73 Files

Subscribers

Details

Reviewers

Commits

rG57d879534096: igc: Remove a bogus register write in igc_if_queues_free()
rG16b24ba87227: igc: Remove a bogus register write in igc_if_queues_free()
rG35d05a14ed7e: igc: Remove a bogus register write in igc_if_queues_free()

Summary

As explained in PR 277038, iflib calls IFDI_DETACH() and then
IFDI_QUEUES_FREE(). With igc, the latter writes to a register after it
has been unmapped.

igc_if_detach() already calls igc_release_hw_control(), and looking at
callers of igc_if_queues_free(), that appears to be sufficient. So,
just remove the igc_release_hw_control() call.

PR: 277038
Diagnosed by: Mike Belanger <mibelanger@qnx.com>

Test Plan

I have no igc hardware and can't test this, any testing would be appreciated.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60202
Build 57086: arc lint + arc unit

Event Timeline

markj created this revision.Oct 26 2024, 5:22 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 26 2024, 5:22 PM

Harbormaster completed remote builds in B60202: Diff 145484.Oct 26 2024, 5:22 PM

markj requested review of this revision.Oct 26 2024, 5:22 PM

markj edited the test plan for this revision. (Show Details)Oct 26 2024, 5:22 PM

This change looks logically correct to me and matches e1000.

I have tested on an I225-IT(2) using devctl and see no issues with attach/detach.

This revision is now accepted and ready to land.Oct 26 2024, 8:04 PM

Closed by commit rG35d05a14ed7e: igc: Remove a bogus register write in igc_if_queues_free() (authored by markj). · Explain WhyOct 26 2024, 9:06 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG35d05a14ed7e: igc: Remove a bogus register write in igc_if_queues_free().

markj added a commit: rG16b24ba87227: igc: Remove a bogus register write in igc_if_queues_free().Nov 2 2024, 2:29 PM

markj added a commit: rG57d879534096: igc: Remove a bogus register write in igc_if_queues_free().

Revision Contents
Changeset List

Path

Size

sys/

dev/

igc/

2 lines

Diff 145484

sys/dev/igc/if_igc.c

Loading...