pctrie: add function to transfer between pctries
AbandonedPublic
Actions

Authored by dougm on Oct 23 2024, 10:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 24, 6:38 AM

	Unknown Object (File)
	Wed, Sep 23, 8:15 AM

	Unknown Object (File)
	Sat, Sep 19, 2:44 AM

	Unknown Object (File)
	Sun, Sep 6, 4:04 PM

	Unknown Object (File)
	Sun, Sep 6, 4:04 PM

	Unknown Object (File)
	Sun, Sep 6, 3:18 PM

	Unknown Object (File)
	Sun, Sep 6, 1:09 PM

	Unknown Object (File)
	Sun, Sep 6, 1:53 AM

View All Files

Subscribers

bnovkov

Details

Reviewers

markj

Summary

vm_page_rename, in order to move a page from one pctrie to another and renumber it, changes its index value back and forth and leaves it briefly inserted in two pctries at once. Add a new transfer function to do all this, and use it in vm_page_rename.

This depends on D46895.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm requested review of this revision.Oct 23 2024, 10:42 PM

dougm created this revision.

bnovkov added a subscriber: bnovkov.Oct 24 2024, 5:18 PM

bnovkov mentioned this in D46895: pctrie: unlock writes without smr.Oct 24 2024, 5:48 PM

dougm mentioned this in D46724: vm_object: use pciters to remove pages.Nov 13 2024, 8:54 AM

markj added inline comments.Nov 13 2024, 3:31 PM

sys/vm/vm_page.c
2002	If I'm reading this correctly, `m`'s pindex is now set to the new pindex when executing vm_page_object_remove(m), but that routine expects the old pindex to still be in place. For example, vm_pager_page_unswapped()->swap_pager_unswapped() looks up a swap block using the page's pindex.
sys/vm/vm_radix.h
306
307
320