fixup_pci: Remove unused attach DEVMETHOD
ClosedPublic
Actions

Authored by jhb on Oct 21 2024, 2:35 PM.

Details

Reviewers

Commits

rG3cc3bfe4ea98: fixup_pci: Remove unused attach DEVMETHOD
rG1f398acbc991: fixup_pci: Remove unused attach DEVMETHOD
rG1cddce89ce30: fixup_pci: Remove unused attach DEVMETHOD

Summary

The probe routine always fails, so the attach routine is unused.
However, this weird driver is really a quirk system for PCI and should
be turned into PCI quirks instead. The Natoma quirk is also broken as
it should be doing a runtime check either on mp_ncpus (or more likely
to see if it is using APIC) instead of #ifdef.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60119
Build 57003: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Oct 21 2024, 2:35 PM

jhb created this revision.

Harbormaster completed remote builds in B60119: Diff 145272.Oct 21 2024, 2:35 PM

jhb added a child revision: D47220: ignore_pci: Add a proper stub attach routine.Oct 21 2024, 2:35 PM

Side note: Do we even run on h/w that needs PCI quirks anymore?

This revision is now accepted and ready to land.Oct 31 2024, 5:03 PM

In D47219#1080186, @imp wrote:

Side note: Do we even run on h/w that needs PCI quirks anymore?

i386 might, but we should be able to axe this as part of the i386 kernel axing in the future. Maybe we should make this driver i386-only? (Move it to files.i386 if not already?)

Closed by commit rG1cddce89ce30: fixup_pci: Remove unused attach DEVMETHOD (authored by jhb). · Explain WhyOct 31 2024, 7:53 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1cddce89ce30: fixup_pci: Remove unused attach DEVMETHOD.

jhb added a commit: rG1f398acbc991: fixup_pci: Remove unused attach DEVMETHOD.Sun, Dec 1, 4:57 AM

jhb added a commit: rG3cc3bfe4ea98: fixup_pci: Remove unused attach DEVMETHOD.