Details

sys/dev/hyperv/include/hyperv.h
127 ↗	(On Diff #14359)	Add "const" for "hv_guid *"
sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
305 ↗	(On Diff #14359)	add "const" for the guid pointer.
308 ↗	(On Diff #14359)	add "const unsigned" for d. Note: unsigned is a must here, or *d can signed-expand to 0xFFFFFFxx and cause a trimmed string...
312 ↗	(On Diff #14359)	It should be d[3], d[2], d[1], d[0], d[5], d[4], d[7], d[6], See https://en.wikipedia.org/wiki/Globally_unique_identifier (the first 4+2+2 bytes are in little endian on x86)
314 ↗	(On Diff #14359)	before "return", add KASSERT(cnt < sz, ("snprintf_hv_guid: too small buf: cnt=%d!\n", cnt));

Update guid print function

Add const and KASSERT too?
Just to make sure people can't pass a too small buf size by mistake (the exact buf size needed here is 37).

add const

In D5651#120865, @decui_microsoft.com wrote:

Add const and KASSERT too?

I didn't see your comments before I made the change. I added const.

Just to make sure people can't pass a too small buf size by mistake (the exact buf size needed here is 37).

I don't agree on this since snprintf in general should not panic if buf is not enough. this function should inherit that behavior.

address review feedback

I'm Ok without the KASSERT.

LGTM

This revision is now accepted and ready to land.Mar 18 2016, 3:18 AM

Can u review?

sepherosa_gmail.com edited edge metadata.

This revision was automatically updated to reflect the committed changes.

hyperv/vmbus: introduce snprinf_hv_guid
ClosedPublic
Actions