the proper way
ClosedPublic
Actions

Authored by kevans on Sep 30 2024, 9:03 PM.

Details

Reviewers

jrtc27
imp

Commits

rG83069000750d: cross-build: fix missing <sys/md4.h> the proper way

Summary

Add it to tools/build/Makefile with a short note of where it's needed,
rather than hamfistedly copying it into the tools/build hierarchy.

Pointed out by: jrtc27

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59662
Build 56549: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Sep 30 2024, 9:03 PM

kevans created this revision.

Harbormaster completed remote builds in B59662: Diff 144062.Sep 30 2024, 9:03 PM

Results here: https://github.com/kevans91/freebsd/actions/runs/11114004259

Could be guarded by !FreeBSD (AFAICT this isn’t?) but I don’t see a problem with doing it there too.

This revision is now accepted and ready to land.Oct 1 2024, 1:29 PM

Closed by commit rG83069000750d: cross-build: fix missing <sys/md4.h> the proper way (authored by kevans). · Explain WhyOct 18 2024, 8:54 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG83069000750d: cross-build: fix missing <sys/md4.h> the proper way.

Revision Contents
Changeset List

Path

Size

tools/

build/

Makefile

2 lines

cross-build/

include/

common/

sys/

md4.h

Diff 144062

View Options

tools/build/Makefile

Show First 20 Lines • Show All 1,747 Lines • ▼ Show 20 Lines	vm_page_alloc_after(vm_object_t object, vm_pindex_t pindex,
int domain;		int domain;

vm_domainset_iter_page_init(&di, object, pindex, &domain, &req);		vm_domainset_iter_page_init(&di, object, pindex, &domain, &req);
do {		do {
m = vm_page_alloc_domain_after(object, pindex, domain, req,		m = vm_page_alloc_domain_after(object, pindex, domain, req,
mpred);		mpred);
if (m != NULL)		if (m != NULL)
break;		break;
} while (vm_domainset_iter_page(&di, &domain, &req) == 0);		} while (vm_domainset_iter_page(&di, object, &domain) == 0);

return (m);		return (m);
}		}

/*		/*
* Returns true if the number of free pages exceeds the minimum		* Returns true if the number of free pages exceeds the minimum
* for the request class and false otherwise.		* for the request class and false otherwise.
*/		*/
▲ Show 20 Lines • Show All 220 Lines • ▼ Show 20 Lines	vm_page_alloc_contig(vm_object_t object, vm_pindex_t pindex, int req,
int domain;		int domain;

vm_domainset_iter_page_init(&di, object, pindex, &domain, &req);		vm_domainset_iter_page_init(&di, object, pindex, &domain, &req);
do {		do {
m = vm_page_alloc_contig_domain(object, pindex, domain, req,		m = vm_page_alloc_contig_domain(object, pindex, domain, req,
npages, low, high, alignment, boundary, memattr);		npages, low, high, alignment, boundary, memattr);
if (m != NULL)		if (m != NULL)
break;		break;
} while (vm_domainset_iter_page(&di, &domain, &req) == 0);		} while (vm_domainset_iter_page(&di, object, &domain) == 0);

return (m);		return (m);
}		}

vm_page_t		vm_page_t
vm_page_alloc_contig_domain(vm_object_t object, vm_pindex_t pindex, int domain,		vm_page_alloc_contig_domain(vm_object_t object, vm_pindex_t pindex, int domain,
int req, u_long npages, vm_paddr_t low, vm_paddr_t high, u_long alignment,		int req, u_long npages, vm_paddr_t low, vm_paddr_t high, u_long alignment,
vm_paddr_t boundary, vm_memattr_t memattr)		vm_paddr_t boundary, vm_memattr_t memattr)
▲ Show 20 Lines • Show All 184 Lines • ▼ Show 20 Lines	vm_page_alloc_freelist(int freelist, int req)
vm_page_t m;		vm_page_t m;
int domain;		int domain;

vm_domainset_iter_page_init(&di, NULL, 0, &domain, &req);		vm_domainset_iter_page_init(&di, NULL, 0, &domain, &req);
do {		do {
m = vm_page_alloc_freelist_domain(domain, freelist, req);		m = vm_page_alloc_freelist_domain(domain, freelist, req);
if (m != NULL)		if (m != NULL)
break;		break;
} while (vm_domainset_iter_page(&di, &domain, &req) == 0);		} while (vm_domainset_iter_page(&di, NULL, &domain) == 0);

return (m);		return (m);
}		}

vm_page_t		vm_page_t
vm_page_alloc_freelist_domain(int domain, int freelist, int req)		vm_page_alloc_freelist_domain(int domain, int freelist, int req)
{		{
struct vm_domain *vmd;		struct vm_domain *vmd;
▲ Show 20 Lines • Show All 622 Lines • ▼ Show 20 Lines	vm_page_reclaim_contig(int req, u_long npages, vm_paddr_t low, vm_paddr_t high,
bool ret;		bool ret;

vm_domainset_iter_page_init(&di, NULL, 0, &domain, &req);		vm_domainset_iter_page_init(&di, NULL, 0, &domain, &req);
do {		do {
ret = vm_page_reclaim_contig_domain(domain, req, npages, low,		ret = vm_page_reclaim_contig_domain(domain, req, npages, low,
high, alignment, boundary);		high, alignment, boundary);
if (ret)		if (ret)
break;		break;
} while (vm_domainset_iter_page(&di, &domain, &req) == 0);		} while (vm_domainset_iter_page(&di, NULL, &domain) == 0);

return (ret);		return (ret);
}		}

/*		/*
* Set the domain in the appropriate page level domainset.		* Set the domain in the appropriate page level domainset.
*/		*/
void		void
▲ Show 20 Lines • Show All 1,678 Lines • Show Last 20 Lines