Page MenuHomeFreeBSD
Differential D46372

ena: Fix leaking ifmedia resources on detach
AcceptedPublic
Actions

Authored by osamaabb_amazon.com on Aug 20 2024, 8:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 23, 5:10 PM
Unknown Object (File)
Sep 28 2024, 1:30 PM
Unknown Object (File)
Sep 27 2024, 1:00 AM
Unknown Object (File)
Sep 23 2024, 2:11 PM
Unknown Object (File)
Sep 23 2024, 2:10 PM
Unknown Object (File)
Sep 23 2024, 2:01 PM
Unknown Object (File)
Sep 20 2024, 2:04 AM
Unknown Object (File)
Sep 19 2024, 3:35 AM
View All 21 Files
Subscribers
imp
zlei

Details

Reviewers
cperciva
zlei
Summary

ifmedia_add() allocates an ifmedia_entry during ena_attach.
Current code doesn't release this memory during ena_detach()

This commit calls ifmedia_removeall() to properly free the
allocated memory during ena_detach().

This bug was first described in:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278100

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

osamaabb_amazon.com created this revision.Aug 20 2024, 8:47 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 20 2024, 8:47 AM
osamaabb_amazon.com requested review of this revision.Aug 20 2024, 8:47 AM
Harbormaster completed remote builds in B59101: Diff 142231.Aug 20 2024, 8:47 AM
zlei accepted this revision.Aug 21 2024, 2:41 AM
zlei added a subscriber: zlei.

Do not forget ifmedia_removeall() for the label err_detach.

sys/dev/ena/ena.c
3981

Do not forget this.

This revision is now accepted and ready to land.Aug 21 2024, 2:41 AM
cperciva added inline comments.Sep 18 2024, 10:53 AM
sys/dev/ena/ena.c
3981

@osamaabb_amazon.com You're going to add the ifmedia_removeall call here?

osamaabb_amazon.com updated this revision to Diff 143636.Sep 23 2024, 2:11 PM
This revision now requires review to proceed.Sep 23 2024, 2:11 PM
osamaabb_amazon.com added inline comments.Sep 23 2024, 2:12 PM
sys/dev/ena/ena.c
3981

Nice catch, thanks!

3981

Addressed

zlei accepted this revision.Sep 24 2024, 5:10 AM
This revision is now accepted and ready to land.Sep 24 2024, 5:10 AM
osamaabb_amazon.com edited the summary of this revision. (Show Details)Mon, Oct 14, 11:01 AM
osamaabb_amazon.com edited the summary of this revision. (Show Details)Mon, Oct 14, 11:03 AM
osamaabb_amazon.com removed a reviewer: zlei.
This revision now requires review to proceed.Mon, Oct 14, 11:03 AM
osamaabb_amazon.com edited the summary of this revision. (Show Details)Mon, Oct 14, 11:03 AM
osamaabb_amazon.com added a reviewer: zlei.
zlei accepted this revision.Mon, Oct 14, 1:05 PM
This revision is now accepted and ready to land.Mon, Oct 14, 1:05 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
ena/
3 lines

Diff 143636

View Options

sys/dev/ena/ena.c

Loading...