Differential D46676

pflogd: Define structures removed in libpcap-1.10.5
ClosedPublic
Actions

Authored by jrm on Sep 14 2024, 7:57 PM.

Tags

None

Referenced Files

	F102082392: D46676.diff
	Thu, Nov 7, 9:57 AM

	Unknown Object (File)
	Fri, Oct 18, 4:45 PM

	Unknown Object (File)
	Fri, Oct 18, 4:45 PM

	Unknown Object (File)
	Fri, Oct 18, 4:44 PM

	Unknown Object (File)
	Fri, Oct 18, 4:44 PM

	Unknown Object (File)
	Fri, Oct 18, 4:44 PM

	Unknown Object (File)
	Fri, Oct 18, 4:11 PM

	Unknown Object (File)
	Thu, Oct 17, 2:32 PM

View All 41 Files

Subscribers

Details

Reviewers

Commits

rGf0bcebe67ef6: pflogd: Define structures removed in libpcap-1.10.5

Summary

In libpcap-1.10.5, two structures that we rely on, pcap_timeval and
pcap_sf_pkthdr, were made private.

https://github.com/the-tcpdump-group/libpcap/commit/c2d8cbb977963be1f6cb07863e5bb59609e87fae

Temporarily define them here to fix the build. kp and I will
investigate a permanent solution at EuroBSDCon in Dublin.

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 59491
Build 56378: arc lint + arc unit

Event Timeline

jrm created this revision.Sep 14 2024, 7:57 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 14 2024, 7:57 PM

jrm requested review of this revision.Sep 14 2024, 7:57 PM

Harbormaster completed remote builds in B59489: Diff 143347.Sep 14 2024, 7:57 PM

Remove unintended changes

Harbormaster completed remote builds in B59490: Diff 143348.Sep 14 2024, 8:00 PM

Fix commit log header

Harbormaster completed remote builds in B59491: Diff 143349.Sep 14 2024, 8:04 PM

jrm retitled this revision from pdflogd: Define structures removed in libpcap-1.10.5 to pflogd: Define structures removed in libpcap-1.10.5.Sep 14 2024, 8:04 PM

jrm edited the summary of this revision. (Show Details)Sep 14 2024, 8:07 PM

jrm edited the summary of this revision. (Show Details)

kp accepted this revision.Sep 14 2024, 8:25 PM

This revision is now accepted and ready to land.Sep 14 2024, 8:25 PM

Closed by commit rGf0bcebe67ef6: pflogd: Define structures removed in libpcap-1.10.5 (authored by jrm). · Explain WhySep 14 2024, 8:30 PM

This revision was automatically updated to reflect the committed changes.

jrm added a commit: rGf0bcebe67ef6: pflogd: Define structures removed in libpcap-1.10.5.

Revision Contents
Changeset List

Path

Size

contrib/

pf/

pflogd/

13 lines

Diff 143349

contrib/pf/pflogd/pflogd.h

Loading...