Page MenuHomeFreeBSD
Differential D46470

geom_disk: Print attachment in boot log like newbus
AcceptedPublic
Actions

Authored by jrtc27 on Aug 28 2024, 11:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 16, 12:23 PM
Unknown Object (File)
Sun, Jun 29, 10:39 PM
Unknown Object (File)
Thu, Jun 26, 9:13 PM
Unknown Object (File)
Jun 17 2025, 6:22 AM
Unknown Object (File)
Jun 14 2025, 11:30 PM
Unknown Object (File)
Jun 8 2025, 9:24 PM
Unknown Object (File)
Jun 2 2025, 1:40 AM
Unknown Object (File)
Jun 2 2025, 1:38 AM
View All 33 Files
Subscribers
None

Details

Reviewers
imp
mav
Summary

If the attachment is known, print "GEOM: new disk A on B" so the
hierarchy is discernible from the log.

MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59220
Build 56107: arc lint + arc unit

Event Timeline

jrtc27 requested review of this revision.Aug 28 2024, 11:53 PM
jrtc27 created this revision.
Harbormaster completed remote builds in B59220: Diff 142579.Aug 28 2024, 11:53 PM
mav added a comment.Aug 29 2024, 1:28 AM

I suppose 3 printf's may cause garbled output if other printf's are used by something.

jrtc27 added a comment.Aug 29 2024, 1:39 AM
In D46470#1059232, @mav wrote:

I suppose 3 printf's may cause garbled output if other printf's are used by something.

Yeah, I could use an sbuf, or duplicate the format string for the two cases. I don't really know what's best, so I picked the simplest of the three... depends how important this is really.

imp added a comment.Aug 29 2024, 1:42 AM
In D46470#1059235, @jrtc27 wrote:
In D46470#1059232, @mav wrote:

I suppose 3 printf's may cause garbled output if other printf's are used by something.

Yeah, I could use an sbuf, or duplicate the format string for the two cases. I don't really know what's best, so I picked the simplest of the three... depends how important this is really.

Please use an sbuf. They will be garbled on systems with lots of disks because each target can proceed in parallel. This used to be a big problem with CAM until Scott fixed it.

jrtc27 added a comment.Aug 29 2024, 1:44 AM
In D46470#1059236, @imp wrote:
In D46470#1059235, @jrtc27 wrote:
In D46470#1059232, @mav wrote:

I suppose 3 printf's may cause garbled output if other printf's are used by something.

Yeah, I could use an sbuf, or duplicate the format string for the two cases. I don't really know what's best, so I picked the simplest of the three... depends how important this is really.

Please use an sbuf. They will be garbled on systems with lots of disks because each target can proceed in parallel. This used to be a big problem with CAM until Scott fixed it.

Ok.

jrtc27 added a comment.Aug 29 2024, 1:52 AM
In D46470#1059237, @jrtc27 wrote:
In D46470#1059236, @imp wrote:
In D46470#1059235, @jrtc27 wrote:
In D46470#1059232, @mav wrote:

I suppose 3 printf's may cause garbled output if other printf's are used by something.

Yeah, I could use an sbuf, or duplicate the format string for the two cases. I don't really know what's best, so I picked the simplest of the three... depends how important this is really.

Please use an sbuf. They will be garbled on systems with lots of disks because each target can proceed in parallel. This used to be a big problem with CAM until Scott fixed it.

Ok.

sbuf_new_auto? sbuf_new with NOWAIT? sbuf_new with a fixed buffer, and if so, how big? Or just do the stupid "hard-code each printf" that avoids any allocation and sbuf fanciness?

jrtc27 updated this revision to Diff 142603.Aug 29 2024, 6:34 PM

Avoid splitting printf via sneaky conditional operator

Harbormaster completed remote builds in B59236: Diff 142603.Aug 29 2024, 6:34 PM
mav accepted this revision.Aug 30 2024, 5:27 PM
This revision is now accepted and ready to land.Aug 30 2024, 5:27 PM
imp accepted this revision.Aug 31 2024, 2:32 PM

Revision Contents
Changeset List

PathSize
sys/
geom/
8 lines

Diff 142579

View Options

sys/geom/geom_disk.c

Loading...