This allows geom(8) to display the attachment such that an unprivileged
user can link up geom disks with their newbus counterparts, just as
diskinfo(8) can already do today with a device ioctl.
MFC after: 1 month
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 59219 Build 56106: arc lint + arc unit
Event Timeline
| sys/geom/geom_disk.c | ||
|---|---|---|
| 638 | Hm, we don't actually need this to be overridable, it's always going to be a static thing drivers can just set to the right value. Will simplify by always using d_attachment, which is also simplifying for another change I'd like to make. | |
Comment Actions
It seems BIO_GETATTR allows GEOM::attachment override. Though I am not saying it is very useful.
Comment Actions
I think it's more to allow BIO_GETATTRY as a way for userspace to query it. GEOM::fw{head,sector}s are similarly handled like that for BIO_GETATTR yet we don't consider d_getattr overriding them. GEOM::ident is a bit of a special case to allow it to be dynamic even though there's a d_ident (as per your rGccba710262443cf4cf2350f173750cf51572d3b9).
Comment Actions
There's a lot of other attributes that would be useful to export... but this is a good start.
I lean towards direct access here because geom_disk is allowed to know about itself...