Page MenuHomeFreeBSD
Differential D5582

Update to 0.2.1, add DOCS and NLS options
ClosedPublic
Actions

Authored by olivier on Mar 8 2016, 6:15 PM.
Tags
None
Referenced Files
F126886372: D5582.id14191.diff
Mon, Aug 25, 6:19 AM
F126886371: D5582.id14171.diff
Mon, Aug 25, 6:19 AM
F126886366: D5582.id.diff
Mon, Aug 25, 6:19 AM
F126885699: D5582.diff
Mon, Aug 25, 6:06 AM
Unknown Object (File)
Fri, Aug 15, 11:08 AM
Unknown Object (File)
Sat, Jul 26, 10:00 PM
Unknown Object (File)
Jul 18 2025, 10:21 AM
Unknown Object (File)
Jul 5 2025, 12:43 PM
View All Files
Subscribers
mat

Details

Reviewers
tabthorpe
jadawin
Commits
rP410700: Update to 0.2.1, add DOCS and NLS options
Summary

Poudriere testport logs available here:

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2820
Build 2844: arc lint + arc unit

Event Timeline

olivier updated this revision to Diff 14171.Mar 8 2016, 6:15 PM
olivier retitled this revision from to Update to 0.2.1, add DOCS and NLS options.
olivier updated this object.
olivier edited the test plan for this revision. (Show Details)
olivier added reviewers: jadawin, tabthorpe.
Herald added a subscriber: mat. · View Herald TranscriptMar 8 2016, 6:15 PM
mat added inline comments.Mar 8 2016, 8:51 PM
deskutils/deforaos-todo/Makefile
23–25

Don't use += here, there's nothing to add to. (Well, unless there's a slave port, but I doubt it.)

olivier added a comment.Mar 9 2016, 8:11 AM

If I didn't add this line:

MAKE_ENV+=        MANDIR=${STAGEDIR}${MANPREFIX}/man

This port wants to install man page in ${PREFIX}/share/man in place of ${PREFIX}/man

mat added a comment.Mar 9 2016, 10:53 AM
In D5582#119287, @olivier wrote:

If I didn't add this line:

MAKE_ENV+=        MANDIR=${STAGEDIR}${MANPREFIX}/man

This port wants to install man page in ${PREFIX}/share/man in place of ${PREFIX}/man

Yes, but why += ? There's no reference of that variable before, so you can replace the += with a =.

jadawin accepted this revision.Mar 9 2016, 12:47 PM
jadawin edited edge metadata.

It is a "cosmetic" change because it changes nothing in port. But, true, += is useless here. Approved in both case, but MAKE_ENV = is better.

This revision is now accepted and ready to land.Mar 9 2016, 12:47 PM
Closed by commit rP410700: Update to 0.2.1, add DOCS and NLS options (authored by olivier). · Explain WhyMar 9 2016, 1:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
deskutils/
deforaos-todo/
33 lines
4 lines
11 lines
7 lines

Diff 14171

View Options

deskutils/deforaos-todo/Makefile

Loading...
View Options

deskutils/deforaos-todo/distinfo

Loading...
View Options

deskutils/deforaos-todo/files/

Loading...
View Options

deskutils/deforaos-todo/files/patch-doc_Makefile

Loading...
View Options

deskutils/deforaos-todo/pkg-plist

Loading...