Page MenuHomeFreeBSD

Update to 0.2.1, add DOCS and NLS options
ClosedPublic

Authored by olivier on Mar 8 2016, 6:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 7:36 AM
Unknown Object (File)
Tue, Mar 5, 7:36 AM
Unknown Object (File)
Tue, Mar 5, 7:36 AM
Unknown Object (File)
Mon, Mar 4, 2:34 PM
Unknown Object (File)
Dec 31 2023, 2:37 AM
Unknown Object (File)
Dec 30 2023, 3:05 PM
Unknown Object (File)
Dec 30 2023, 3:05 PM
Unknown Object (File)
Dec 30 2023, 3:05 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olivier retitled this revision from to Update to 0.2.1, add DOCS and NLS options.
olivier updated this object.
olivier edited the test plan for this revision. (Show Details)
olivier added reviewers: jadawin, tabthorpe.
deskutils/deforaos-todo/Makefile
23–25 ↗(On Diff #14171)

Don't use += here, there's nothing to add to. (Well, unless there's a slave port, but I doubt it.)

If I didn't add this line:

MAKE_ENV+=        MANDIR=${STAGEDIR}${MANPREFIX}/man

This port wants to install man page in ${PREFIX}/share/man in place of ${PREFIX}/man

If I didn't add this line:

MAKE_ENV+=        MANDIR=${STAGEDIR}${MANPREFIX}/man

This port wants to install man page in ${PREFIX}/share/man in place of ${PREFIX}/man

Yes, but why += ? There's no reference of that variable before, so you can replace the += with a =.

jadawin edited edge metadata.

It is a "cosmetic" change because it changes nothing in port. But, true, += is useless here. Approved in both case, but MAKE_ENV = is better.

This revision is now accepted and ready to land.Mar 9 2016, 12:47 PM
This revision was automatically updated to reflect the committed changes.