Page MenuHomeFreeBSD
Differential D46033

cam/iosched: Add a counter of I/Os that take too long
ClosedPublic
Actions

Authored by imp on Jul 18 2024, 10:02 PM.
Tags
None
Referenced Files
F167803619: D46033.id141167.diff
Mon, Aug 24, 4:23 PM
Unknown Object (File)
Sat, Aug 22, 8:44 AM
Unknown Object (File)
Tue, Aug 11, 10:37 PM
Unknown Object (File)
Tue, Aug 11, 10:37 PM
Unknown Object (File)
Tue, Aug 11, 7:17 PM
Unknown Object (File)
Tue, Aug 11, 4:34 PM
Unknown Object (File)
Sun, Aug 9, 1:44 PM
Unknown Object (File)
Sat, Aug 8, 5:39 PM
View All Files
Subscribers
None

Details

Reviewers
mav
jhb
Group Reviewers
cam
Commits
rGe82644e59ece: cam/iosched: Add a counter of I/Os that take too long
Summary

Add kern.cam.DEV.UNIT.iosched.too_long (to count I/Os taking too long)
and kern.cam.DEV.UNIT.bad_latency (to set this threshold, defaults to
500ms). Each class of I/O (read, write, trim) has its own counters and
thresholds.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58716
Build 55604: arc lint + arc unit

Event Timeline

imp created this revision.Jul 18 2024, 10:02 PM
Herald added a reviewer: cam. · View Herald TranscriptJul 18 2024, 10:02 PM
Harbormaster completed remote builds in B58716: Diff 141097.Jul 18 2024, 10:02 PM
imp requested review of this revision.Jul 18 2024, 10:02 PM
imp added a parent revision: D46032: ada/da: Ignore CCBs at wrong priority in *start.
imp added a child revision: D46034: cam/iosched: Pass the transaction down we're collecting stats for.
imp added a child revision: D46038: cam/iosched: Make each periph driver provide schedule fnp.Jul 19 2024, 4:19 AM
imp removed a child revision: D46038: cam/iosched: Make each periph driver provide schedule fnp.
imp removed a parent revision: D46032: ada/da: Ignore CCBs at wrong priority in *start.
imp updated this revision to Diff 141105.Jul 19 2024, 4:22 AM

Misc updates with testing

Harbormaster completed remote builds in B58721: Diff 141105.Jul 19 2024, 4:22 AM
jhb accepted this revision.Jul 19 2024, 3:25 PM
This revision is now accepted and ready to land.Jul 19 2024, 3:25 PM
Closed by commit rGe82644e59ece: cam/iosched: Add a counter of I/Os that take too long (authored by imp). · Explain WhyJul 20 2024, 2:59 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGe82644e59ece: cam/iosched: Add a counter of I/Os that take too long.

Revision Contents
Changeset List

PathSize
sys/
cam/
21 lines

Diff 141097

View Options

sys/cam/cam_iosched.c

Loading...