Page MenuHomeFreeBSD
Differential D5478

databases/mariadb101-server: Fix i386, GSSAPI & Engine build issues
ClosedPublic
Actions

Authored by brnrd on Feb 27 2016, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 11, 6:44 AM
Unknown Object (File)
Tue, Sep 2, 4:08 PM
Unknown Object (File)
Tue, Sep 2, 3:02 PM
Unknown Object (File)
Aug 14 2025, 9:53 PM
Unknown Object (File)
Aug 14 2025, 12:32 PM
Unknown Object (File)
Jul 20 2025, 1:36 PM
Unknown Object (File)
Jul 19 2025, 4:21 AM
Unknown Object (File)
Jul 17 2025, 10:58 AM
View All Files
Subscribers
None

Details

Reviewers
koobs
feld
Commits
rP410182: databases/mariadb101-server: Fix i386, GSSAPI & Engine build issues
Summary

Proposed commit log:

databases/mariadb101-server: Fix i386, GSSAPI & Engine build issues

 - Add USES=compiler:c++11-lib
 - Use both deprecated -DPLUGIN_${engine} and new -DWITHOUT_${engine}
   to disable engines (fixes engines not being disabled)
 - Add IGNORE for GSSAPI_BASE on FreeBSD < 10, version is too old
 - Add IGNORE for TokuDB, upstream not supported on 32-bit platforms
 - Add IGNORE on i386, currently broken with clang [1]
 
[1] https://jira.mariadb.org/browse/MDEV-9627

Reviewed_by:	feld (mentor), koobs (mentor)
Approved by:	(mentor)
Differential_Revision:	D5478
Test Plan
  • portlint -AC
  • poudriere testport

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brnrd updated this revision to Diff 13834.Feb 27 2016, 7:27 PM
brnrd retitled this revision from to databases/mariadb101-server: Fix build issues.
brnrd updated this object.
brnrd edited the test plan for this revision. (Show Details)
brnrd added reviewers: feld, koobs.
brnrd updated this object.Feb 27 2016, 8:28 PM
brnrd updated this revision to Diff 13843.Feb 28 2016, 9:25 AM

Switch to using NOT_FOR_ARCHS

koobs requested changes to this revision.Mar 5 2016, 10:15 AM
koobs edited edge metadata.

Along with addressing inline comments, update all commit log message itemized changes to:

- <Verb what changed in port>[, rationale if necessary]

For example, update:

Build needs c++11 libs

to

Add USES=compiler:c++11-lib

Update Fix building on 9.3 (base Heimdall too old) to

Add IGNORE for GSSAPI_BASE on FreeBSD < 10, version is too old

databases/mariadb101-server/Makefile
144 ↗(On Diff #13843)

I prefer the original explicit mention of which option (GSSAPI_BASE) needs to be changed

Can GSSAPI_BASE_IGNORE helper be used here as well instead of in the conditional?

158 ↗(On Diff #13843)

'What' requires a Kerberos implementation from ports?

FreeBSD < 10?

Be explicit about what condition resulted in this message to the user

162–166 ↗(On Diff #13843)

Use OPTIONS_VARS

databases/mariadb101-server/files/patch-plugin_auth__gssapi_gssapi__server.cc
1–2 ↗(On Diff #13843)

I prefer raw from upstream headers for commits. For 'issues' or mailing list links, custom headers are fine

databases/mariadb101-server/files/patch-storage_tokudb_PerconaFT_buildheader_CMakeLists.txt
1 ↗(On Diff #13843)

Use the upstream Issue Summary

This revision now requires changes to proceed.Mar 5 2016, 10:15 AM
brnrd updated this object.Mar 5 2016, 10:35 AM
brnrd edited edge metadata.
brnrd updated this revision to Diff 14095.Mar 5 2016, 11:28 AM
brnrd edited edge metadata.
brnrd marked 5 inline comments as done.

Address review comments

databases/mariadb101-server/Makefile
144 ↗(On Diff #13843)

This was changed to pet portlint complaining about first char being upper-case.

GSSAPI_BASE_IGNORE works fine.

162–166 ↗(On Diff #13843)

Transformed into OPTIONS_EXCLUDE_i386

brnrd updated this object.Mar 5 2016, 12:25 PM
brnrd edited edge metadata.
brnrd updated this revision to Diff 14097.Mar 5 2016, 12:28 PM

There is no line-continuation in IGNORE messages

koobs updated this object.Mar 5 2016, 1:32 PM
koobs retitled this revision from databases/mariadb101-server: Fix build issues to databases/mariadb101-server: Fix i386, GSSAPI & Engine build issues.
koobs accepted this revision.Mar 5 2016, 1:34 PM
koobs edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Mar 5 2016, 1:34 PM
brnrd updated this object.Mar 5 2016, 1:55 PM
brnrd edited edge metadata.
Closed by commit rP410182: databases/mariadb101-server: Fix i386, GSSAPI & Engine build issues (authored by brnrd). · Explain WhyMar 5 2016, 1:57 PM
This revision was automatically updated to reflect the committed changes.
brnrd mentioned this in rP410182: databases/mariadb101-server: Fix i386, GSSAPI & Engine build issues.

Revision Contents
Changeset List

Diff 14105

View Options

head/databases/mariadb101-server/Makefile

Loading...
View Options

head/databases/mariadb101-server/files/patch-plugin_auth__gssapi_gssapi__server.cc

Loading...
View Options

head/databases/mariadb101-server/files/patch-storage_tokudb_PerconaFT_buildheader_CMakeLists.txt

Loading...
View Options

head/databases/mariadb101-server/files/patch-storage_tokudb_PerconaFT_cmake__modules_TokuThirdParty.cmake

Loading...