Page MenuHomeFreeBSD
Differential D5541

elfcopy: fail if debug link target is empty
ClosedPublic
Actions

Authored by emaste on Mar 3 2016, 11:21 PM.
Tags
None
Referenced Files
F171210428: D5541.id14050.diff
Wed, Sep 9, 1:29 PM
Unknown Object (File)
Sun, Sep 6, 5:23 PM
Unknown Object (File)
Sun, Sep 6, 5:16 PM
Unknown Object (File)
Sun, Sep 6, 5:10 PM
Unknown Object (File)
Sun, Sep 6, 1:45 PM
Unknown Object (File)
Sun, Sep 6, 8:57 AM
Unknown Object (File)
Sun, Sep 6, 6:52 AM
Unknown Object (File)
Sun, Sep 6, 12:06 AM
View All Files
Subscribers
imp

Details

Reviewers
bdrewery
Commits
rS296391: elfcopy: fail if debug link target is empty
Summary

An empty debug link target previously returned a confusing and incorrect error like "objcopy: fread failed: No error: 0".

GNU objcopy allows an empty file as the debug link target. However, that case is nonsensical so just return an explicit error.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 14050.Mar 3 2016, 11:21 PM
emaste retitled this revision from to elfcopy: fail if debug link target is empty.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: bdrewery.
emaste added a subscriber: imp.
bdrewery accepted this revision.Mar 4 2016, 5:52 PM
bdrewery edited edge metadata.
This revision is now accepted and ready to land.Mar 4 2016, 5:52 PM
Closed by commit rS296391: elfcopy: fail if debug link target is empty (authored by emaste). · Explain WhyMar 4 2016, 6:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
contrib/
elftoolchain/
elfcopy/
3 lines

Diff 14083

View Options

head/contrib/elftoolchain/elfcopy/sections.c

Loading...