Paths

Table of Contentst

netstat: remove gethostby*() calls
Needs ReviewPublic
Actions

Authored by yanhaowang on Jul 9 2024, 3:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jan 25 2026, 2:01 AM

	Unknown Object (File)
	Jan 22 2026, 3:07 PM

	Unknown Object (File)
	Jan 22 2026, 1:55 PM

	Unknown Object (File)
	Jan 17 2026, 6:05 PM

	Unknown Object (File)
	Jan 16 2026, 1:29 AM

	Unknown Object (File)
	Dec 26 2025, 4:48 AM

	Unknown Object (File)
	Dec 11 2025, 6:06 PM

	Unknown Object (File)
	Dec 2 2025, 12:20 AM

View All Files

Subscribers

imp

Details

Reviewers

hrs
lwhsu

Summary

Use getnameinfo with NI_NAMEREQD flag to replace gethostbyaddr.

Test Plan

I just check netstat -4 output and it look similar (just similar because it seem the network status is change anytime) with the origin output.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	usr.bin/netstat/inet.c:	CHMOD1	Invalid Executable

Unit

No Test Coverage

Build Status

Buildable 58577
Build 55465: arc lint + arc unit

Event Timeline

yanhaowang created this revision.Jul 9 2024, 3:51 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 9 2024, 3:51 AM

yanhaowang requested review of this revision.Jul 9 2024, 3:51 AM

Harbormaster completed remote builds in B58577: Diff 140708.Jul 9 2024, 3:51 AM

Fix file permission

Harbormaster completed remote builds in B58578: Diff 140709.Jul 9 2024, 3:52 AM

yanhaowang added reviewers: hrs, lwhsu.Jul 9 2024, 3:52 AM

yanhaowang edited the test plan for this revision. (Show Details)Jul 27 2024, 12:45 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

netstat/

inet.c

14 lines

Diff 140708

View Options

netstat: remove gethostby*() callsNeeds ReviewPublicActions