Page MenuHomeFreeBSD
Differential D5541

elfcopy: fail if debug link target is empty
ClosedPublic
Actions

Authored by emaste on Mar 3 2016, 11:21 PM.
Tags
None
Referenced Files
F151088211: D5541.id14083.diff
Sun, Apr 5, 10:31 PM
Unknown Object (File)
Sun, Mar 29, 2:27 AM
Unknown Object (File)
Thu, Mar 26, 6:07 PM
Unknown Object (File)
Wed, Mar 18, 8:51 AM
Unknown Object (File)
Tue, Mar 17, 1:04 PM
Unknown Object (File)
Tue, Mar 17, 1:01 PM
Unknown Object (File)
Mon, Mar 16, 9:08 PM
Unknown Object (File)
Sun, Mar 15, 4:14 PM
View All Files
Subscribers
imp

Details

Reviewers
bdrewery
Commits
rS296391: elfcopy: fail if debug link target is empty
Summary

An empty debug link target previously returned a confusing and incorrect error like "objcopy: fread failed: No error: 0".

GNU objcopy allows an empty file as the debug link target. However, that case is nonsensical so just return an explicit error.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 14050.Mar 3 2016, 11:21 PM
emaste retitled this revision from to elfcopy: fail if debug link target is empty.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: bdrewery.
emaste added a subscriber: imp.
bdrewery accepted this revision.Mar 4 2016, 5:52 PM
bdrewery edited edge metadata.
This revision is now accepted and ready to land.Mar 4 2016, 5:52 PM
Closed by commit rS296391: elfcopy: fail if debug link target is empty (authored by emaste). · Explain WhyMar 4 2016, 6:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
elfcopy/
3 lines

Diff 14050

View Options

contrib/elftoolchain/elfcopy/sections.c

Loading...