Try to create the debug directory if it does not exist.
ClosedPublic
Actions

Authored by bdrewery on Feb 23 2016, 6:29 PM.

Details

Reviewers

emaste

Commits

rS296353: DEBUG_FILES: Create the DEBUGFILEDIR if it doesn't exist on install.

Summary

HardenedBSD folks reported that they have an out-of-tree LIB that by default
tries to install to /usr/lib and install debug files to /usr/lib/debug.
The /usr/lib/debug directory is not present though since it only comes from the
base-db.txz package.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdrewery updated this revision to Diff 13654.Feb 23 2016, 6:29 PM

bdrewery retitled this revision from to Try to create the debug directory if it does not exist..

bdrewery updated this object.

bdrewery edited the test plan for this revision. (Show Details)

bdrewery added a reviewer: emaste.

Herald added a subscriber: imp. · View Herald TranscriptFeb 23 2016, 6:29 PM

lattera-gmail.com added a subscriber: lattera-gmail.com.Feb 23 2016, 6:29 PM

I went with this route as it cuts down on redundant install -d.

This has been tested successfully by a HardenedBSD user.

HardenedBSD folks reported that they have an out-of-tree LIB that by default
tries to install to /usr/lib and install debug files to /usr/lib/debug.
The /usr/lib/debug directory is not present though since it only comes from the
base-db.txz package.

I'm missing something here; the /usr/lib/debug hierarchy is created unconditionally. This case applies only to a binary installation, then building and installing additional components to go into /usr/lib?

emaste added inline comments.Feb 23 2016, 6:38 PM

share/mk/bsd.lib.mk
145 ↗	(On Diff #13654)	DEBUGFILEDIR should never be empty

In D5411#115275, @emaste wrote:

HardenedBSD folks reported that they have an out-of-tree LIB that by default
tries to install to /usr/lib and install debug files to /usr/lib/debug.
The /usr/lib/debug directory is not present though since it only comes from the
base-db.txz package.

I'm missing something here; the /usr/lib/debug hierarchy is created unconditionally. This case applies only to a binary installation, then building and installing additional components to go into /usr/lib?

Well it's not being added to base.txz.

fetch https://download.freebsd.org/ftp/snapshots/amd64/11.0-CURRENT/base.txz
tar -tf base.txz|grep usr/lib/debug #

DEBUGFILEDIR is never empty.

bdrewery marked an inline comment as done.Feb 23 2016, 6:54 PM

In D5411#115275, @emaste wrote:

HardenedBSD folks reported that they have an out-of-tree LIB that by default
tries to install to /usr/lib and install debug files to /usr/lib/debug.
The /usr/lib/debug directory is not present though since it only comes from the
base-db.txz package.

I'm missing something here; the /usr/lib/debug hierarchy is created unconditionally. This case applies only to a binary installation, then building and installing additional components to go into /usr/lib?

See Makefile.inc1 distributeworld:

.if ${MK_DEBUG_FILES} != "no"
        mtree -deU -f ${.CURDIR}/etc/mtree/BSD.debug.dist \
            -p ${DESTDIR}/${DISTDIR}/${dist}/usr/lib >/dev/null
.endif

It's conditional there (and 2 other places) which is what release/Makefile uses for base.txz.

I'm liking this change better than changing distributeworld to release empty directories.

Closed by commit rS296353: DEBUG_FILES: Create the DEBUGFILEDIR if it doesn't exist on install. (authored by bdrewery). · Explain WhyMar 3 2016, 6:09 PM

This revision was automatically updated to reflect the committed changes.