Page MenuHomeFreeBSD
Differential D45601

ppp: remove gethostby*() calls
Needs ReviewPublic
Actions

Authored by yanhaowang on Jun 16 2024, 3:29 AM.
Tags
None
Referenced Files
F150151043: D45601.diff
Sun, Mar 29, 8:05 PM
Unknown Object (File)
Sat, Mar 28, 7:54 AM
Unknown Object (File)
Sat, Mar 21, 10:23 AM
Unknown Object (File)
Sat, Mar 21, 4:26 AM
Unknown Object (File)
Tue, Mar 17, 3:45 PM
Unknown Object (File)
Tue, Mar 17, 9:04 AM
Unknown Object (File)
Feb 26 2026, 5:40 PM
Unknown Object (File)
Feb 3 2026, 5:36 AM
View All Files
Subscribers
imp

Details

Reviewers
hrs
lwhsu
Summary
  1. Use getaddrinfo to replace gethostbyname, use for loop to loop the address list and copy the first meet ipv4 address.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58186
Build 55074: arc lint + arc unit

Event Timeline

yanhaowang created this revision.Jun 16 2024, 3:29 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 16 2024, 3:29 AM
yanhaowang requested review of this revision.Jun 16 2024, 3:29 AM
Harbormaster completed remote builds in B58186: Diff 139880.Jun 16 2024, 3:29 AM
yanhaowang added reviewers: hrs, lwhsu.Jun 16 2024, 3:34 AM
yanhaowang updated this revision to Diff 139883.Jun 16 2024, 7:42 AM
  • Remove unused variable
Harbormaster completed remote builds in B58187: Diff 139883.Jun 16 2024, 7:42 AM
yanhaowang updated this revision to Diff 140203.Jun 25 2024, 2:44 AM
  • Remove for loop
Harbormaster completed remote builds in B58341: Diff 140203.Jun 25 2024, 2:44 AM
yanhaowang updated this revision to Diff 140648.Jul 7 2024, 7:15 AM

Update according Hiroki advise in D45594

  1. Use "error" instead of "status" name to store the value of getaddrinfo() function.
  2. Use compound literals instead of "hints" variable.
Harbormaster completed remote builds in B58542: Diff 140648.Jul 7 2024, 7:15 AM
yanhaowang updated this revision to Diff 140654.Jul 7 2024, 10:49 AM

Remove unused variable

Harbormaster completed remote builds in B58547: Diff 140654.Jul 7 2024, 10:49 AM
yanhaowang updated this revision to Diff 140673.Jul 8 2024, 7:31 AM

Fix format

Harbormaster completed remote builds in B58558: Diff 140673.Jul 8 2024, 7:31 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
ppp/
27 lines
20 lines
22 lines
32 lines

Diff 139880

View Options

usr.sbin/ppp/defs.c

Loading...
View Options

usr.sbin/ppp/ipcp.c

Loading...
View Options

usr.sbin/ppp/nat_cmd.c

Loading...
View Options

usr.sbin/ppp/radius.c

Loading...