Update to 0.3.0 and add DOCS options
ClosedPublic
Actions

Authored by olivier on Mar 1 2016, 11:38 PM.

Details

Reviewers

tabthorpe
jadawin

Commits

rP409950: Update to 0.3.0 and add DOCS options

Summary

This is the first patch of a full deforaos desktop environnement port upgrade. Because all others patchs will follow the same template, this first need to be carrefully reviewed.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olivier updated this revision to Diff 13959.Mar 1 2016, 11:38 PM

olivier retitled this revision from to Update to 0.3.0 and add DOCS options.

olivier updated this object.

olivier edited the test plan for this revision. (Show Details)

olivier added reviewers: jadawin, tabthorpe.

Herald added a subscriber: mat. · View Herald TranscriptMar 1 2016, 11:38 PM

mat added inline comments.Mar 1 2016, 11:59 PM

devel/deforaos-libsystem/Makefile
34–36 ↗	(On Diff #13959)	This can be changed to: IGNORE_FreeBSD_9=this port works only on FreeBSD 10 and newer And then you don't need the bsd.port.pre.mk include.

Are you sure about IGNORE_FreeBSD_9 ? bsd.port.mk reference only BROKEN_${OPSYS}_${OSREL:R} but not IGNORE_${OPSYS}_${OSREL:R}

BROKEN_FreeBSD_9=<tab>blah blah will works better, I think. Thanks to submit a new review :)

In D5518#117618, @olivier wrote:

Are you sure about IGNORE_FreeBSD_9 ? bsd.port.mk reference only BROKEN_${OPSYS}_${OSREL:R} but not IGNORE_${OPSYS}_${OSREL:R}

Yes, BROKEN_FreeBSD_9, I was half asleep :-)