This is the first patch of a full deforaos desktop environnement port upgrade. Because all others patchs will follow the same template, this first need to be carrefully reviewed.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
devel/deforaos-libsystem/Makefile | ||
---|---|---|
34–36 ↗ | (On Diff #13959) | This can be changed to: IGNORE_FreeBSD_9=this port works only on FreeBSD 10 and newer And then you don't need the bsd.port.pre.mk include. |
Comment Actions
Are you sure about IGNORE_FreeBSD_9 ? bsd.port.mk reference only BROKEN_${OPSYS}_${OSREL:R} but not IGNORE_${OPSYS}_${OSREL:R}
Comment Actions
BROKEN_FreeBSD_9=<tab>blah blah will works better, I think. Thanks to submit a new review :)
devel/deforaos-libsystem/Makefile | ||
---|---|---|
15 ↗ | (On Diff #13981) | Why copying LICENSE_FILE? LGPL3 is a known license. |
devel/deforaos-libsystem/Makefile | ||
---|---|---|
15 ↗ | (On Diff #13981) | Because you must. The only reason to not use LICENSE_FILE is if there is no distributed license file. |