sys/sysctl.h: Fix wrong assertion with multiple access flags
ClosedPublic
Actions

Authored by zlei on Jun 7 2024, 4:46 PM.

Details

Reviewers

erj
imp

Commits

rGc720ff8f95fc: sys/sysctl.h: Fix wrong assertion with multiple access flags
rG9cd77bd9c68b: sys/sysctl.h: Fix wrong assertion with multiple access flags
rG23f4131ad685: sys/sysctl.h: Fix wrong assertion with multiple access flags

Summary

With multiple flags passed in, e.g., CTLFLAG_RD | CTLFLAG_CAPRD, due to
the precedence rules, this will result in false positive assertion. Fix
that by surrounding the replacement lists with parentheses.

Fixes: 10a1e981d411 iflib: mark isc_driver_version as constant
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Jun 7 2024, 4:46 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 7 2024, 4:46 PM

zlei requested review of this revision.Jun 7 2024, 4:46 PM

imp accepted this revision.Jun 7 2024, 5:51 PM

This revision is now accepted and ready to land.Jun 7 2024, 5:51 PM

erj accepted this revision.Jun 7 2024, 7:31 PM

Closed by commit rG23f4131ad685: sys/sysctl.h: Fix wrong assertion with multiple access flags (authored by zlei). · Explain WhyJun 8 2024, 3:23 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG23f4131ad685: sys/sysctl.h: Fix wrong assertion with multiple access flags.

zlei added a commit: rG9cd77bd9c68b: sys/sysctl.h: Fix wrong assertion with multiple access flags.Jun 11 2024, 4:49 AM

zlei added a commit: rGc720ff8f95fc: sys/sysctl.h: Fix wrong assertion with multiple access flags.

Revision Contents
Changeset List

Path

Size

sys/

sysctl.h

4 lines

Diff 139646

View Options

sys/sysctl.h: Fix wrong assertion with multiple access flagsClosedPublicActions