POSIX standard states that yyerror() function supplied to the parser should have the int return type.
So I believe that instead of this patch, two other places in usr.sbin/config should be patched, that do use void.

Updated to return int as suggested by @kib.

kib accepted this revision.Jun 3 2024, 10:09 AM

kib added inline comments.

usr.sbin/config/config.y
307	return (0);

This revision is now accepted and ready to land.Jun 3 2024, 10:09 AM

Added parentheses around the returned value.

This revision now requires review to proceed.Jun 3 2024, 10:26 AM

imp accepted this revision.Jun 3 2024, 1:45 PM

This revision is now accepted and ready to land.Jun 3 2024, 1:45 PM

I can land this too, it looks perfect now.

Closed by commit rG5dda778db634: Use correct function declaration for yyerror (authored by dg612_cam.ac.uk, committed by imp). · Explain WhyJun 3 2024, 6:15 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG5dda778db634: Use correct function declaration for yyerror.

dg612_cam.ac.uk mentioned this in D45464: mkcsmapper: Use correct function declaration for yyerror.Jun 16 2024, 3:14 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

config/

config.y

5 lines

Diff 139352

View Options

Use correct function declaration for yyerrorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 139352

usr.sbin/config/config.y

Use correct function declaration for yyerror
ClosedPublic
Actions

Revision Contents
Changeset List