cross-build: progname.c is used only on linux, so no ifdefs needed
ClosedPublic
Actions

Authored by imp on May 26 2024, 9:21 PM.

Details

Reviewers

jrtc27
val_packett.cool

Commits

rG744991d495b2: cross-build: progname.c is used only on linux, so no ifdefs needed

Summary

The logic in the makefile ensures this is only present on Linux, so no
ifdef is needed. I overlooked comments to the effect in the original
pull request somehow.

Fixes: 0e03402139da
Suggested by: arichards, jrtc27
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57926
Build 54814: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 26 2024, 9:21 PM

imp created this revision.

imp added a parent revision: D45373: cross-build: Move fcntl.h workaround to Linux specific file.

imp added a child revision: D45375: cross-build: Define DEFFILEMODE and ALLPERMS if not defined.

Harbormaster completed remote builds in B57926: Diff 139127.May 26 2024, 9:22 PM

imp mentioned this in D45355: cross-build: This is not glibc specific, but Linux specific.May 26 2024, 9:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 25 2024, 2:49 AM

Closed by commit rG744991d495b2: cross-build: progname.c is used only on linux, so no ifdefs needed (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG744991d495b2: cross-build: progname.c is used only on linux, so no ifdefs needed.

Revision Contents
Changeset List

Path

Size

tools/

build/

cross-build/

progname.c

2 lines

Diff 139127

View Options

tools/build/cross-build/progname.c

cross-build: progname.c is used only on linux, so no ifdefs neededClosedPublicActions