usr.bin/top: fix displaying load average for loads of at least 100
ClosedPublic
Actions

Authored by pkubaj on May 21 2024, 10:34 AM.

Details

Reviewers

markj
imp
kib

Commits

rGb7f62c6042f8: usr.bin/top: fix displaying load average for loads of at least 100

Summary

After top registers load average of at least 100 which then gets reduced to
below 100, there are left stray digits.
Supporting load over 100 requires increasing the width only to 6, but since
we support over 1000 CPU's now, let's increase it to 7.

Test Plan

Run top while running with load over 100 (or even better, over 1000) which
then gets reduced to below 100.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pkubaj requested review of this revision.May 21 2024, 10:34 AM

pkubaj created this revision.

Harbormaster completed remote builds in B57815: Diff 138837.May 21 2024, 10:34 AM

So for mostly idle machines, this increases the spacing between ':', ',', and values. Perhaps doing it conditionally is worse because the placement of the values would blink.

This revision is now accepted and ready to land.May 21 2024, 9:13 PM

Closed by commit rGb7f62c6042f8: usr.bin/top: fix displaying load average for loads of at least 100 (authored by pkubaj). · Explain WhyMay 22 2024, 2:48 PM

This revision was automatically updated to reflect the committed changes.

pkubaj added a commit: rGb7f62c6042f8: usr.bin/top: fix displaying load average for loads of at least 100.